Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2234)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 2799443002: Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox. (Closed)
Patch Set: Fixed Blink test.# with '#' will be ignored, and an empty message aborts the commit. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/automation.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
index 3ce0930b59b0a7558d0b8cf2483950d7b42c6c20..982a3ea45b3a990f9a353cae1a7c04e8b49a348c 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
@@ -427,10 +427,14 @@ Output.RULES = {
speak: '$earcon(ALERT_MODAL) $name $nameOrTextContent $state $role'
},
cell: {
- enter: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
- '$node(tableColumnHeader)',
- speak: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
- '$node(tableColumnHeader) $state'
+ enter: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex, ' +
+ '$tableCellRowIndex), ' +
+ '$if($ariaCellColumnIndex, $ariaCellColumnIndex, ' +
+ '$tableCellColumnIndex)) $node(tableColumnHeader)',
+ speak: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex, ' +
+ '$tableCellRowIndex), ' +
+ '$if($ariaCellColumnIndex, $ariaCellColumnIndex, ' +
+ '$tableCellColumnIndex)) $node(tableColumnHeader) $state'
},
checkBox: {
speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
@@ -564,7 +568,9 @@ Output.RULES = {
'$if($setSize, @describe_index($posInSet, $setSize))',
},
table: {
- enter: '@table_summary($name, $tableRowCount, $tableColumnCount) ' +
+ enter: '@table_summary($name, ' +
+ '$if($ariaRowCount, $ariaRowCount, $tableRowCount), ' +
+ '$if($ariaColumnCount, $ariaColumnCount, $tableColumnCount)) ' +
'$node(tableHeader)'
},
tableHeaderContainer: {
« no previous file with comments | « no previous file | chrome/common/extensions/api/automation.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698