content/renderer/accessibility/blink_ax_tree_source.cc - Issue 2799443002: Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2799443002: Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox. (Closed)

Patch Set: Fixed Blink test.# with '#' will be ignored, and an empty message aborts the commit. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index f2743d8115daaca9e164346fce61a8c191f7328a..397c86e42ad0ce14085125a9a9e722163783a016 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -706,7 +706,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

int aria_colcount = src.AriaColumnCount();

if (aria_colcount)

- dst->AddIntAttribute(ui::AX_ATTR_ARIA_COL_COUNT, aria_colcount);

+ dst->AddIntAttribute(ui::AX_ATTR_ARIA_COLUMN_COUNT, aria_colcount);

int aria_rowcount = src.AriaRowCount();

if (aria_rowcount)

@@ -742,13 +742,15 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

src.CellRowSpan());

int aria_colindex = src.AriaColumnIndex();

- if (aria_colindex)

- dst->AddIntAttribute(ui::AX_ATTR_ARIA_COL_INDEX, aria_colindex);

+ if (aria_colindex) {

+ dst->AddIntAttribute(ui::AX_ATTR_ARIA_CELL_COLUMN_INDEX,

+ aria_colindex);

+ }

}

int aria_rowindex = src.AriaRowIndex();

if (aria_rowindex)

- dst->AddIntAttribute(ui::AX_ATTR_ARIA_ROW_INDEX, aria_rowindex);

+ dst->AddIntAttribute(ui::AX_ATTR_ARIA_CELL_ROW_INDEX, aria_rowindex);

}

if ((dst->role == ui::AX_ROLE_ROW_HEADER ||