Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2799363003: A column-span:all element should always establish a new formatting context. (Closed)

Created:
2 years, 1 month ago by mstensho (USE GERRIT)
Modified:
2 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

A column-span:all element should always establish a new formatting context. This also applies when the element isn't contained by a multicol container (which means that we shouldn't require the spanner placeholder to be present). BUG=709362 Review-Url: https://codereview.chromium.org/2799363003 Cr-Commit-Position: refs/heads/master@{#462865} Committed: https://chromium.googlesource.com/chromium/src/+/1c9b66ff417ace5d8cb6b3358389a891b4eb3a3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mstensho (USE GERRIT)
2 years, 1 month ago (2017-04-07 09:05:12 UTC) #3
eae
LGTM
2 years, 1 month ago (2017-04-07 15:17:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799363003/1
2 years, 1 month ago (2017-04-07 15:17:35 UTC) #9
commit-bot: I haz the power
2 years, 1 month ago (2017-04-07 15:22:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c9b66ff417ace5d8cb6b3358389...

Powered by Google App Engine
This is Rietveld 408576698