Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2799363003: A column-span:all element should always establish a new formatting context. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 4743 matching lines...) Expand 10 before | Expand all | Expand 10 after
4754 return node && node->isElementNode() && 4754 return node && node->isElementNode() &&
4755 (toElement(node)->isFormControlElement() || 4755 (toElement(node)->isFormControlElement() ||
4756 isHTMLImageElement(toElement(node))); 4756 isHTMLImageElement(toElement(node)));
4757 } 4757 }
4758 4758
4759 DISABLE_CFI_PERF 4759 DISABLE_CFI_PERF
4760 bool LayoutBox::avoidsFloats() const { 4760 bool LayoutBox::avoidsFloats() const {
4761 // crbug.com/460704: This should be merged with createsNewFormattingContext(). 4761 // crbug.com/460704: This should be merged with createsNewFormattingContext().
4762 return shouldBeConsideredAsReplaced() || hasOverflowClip() || isHR() || 4762 return shouldBeConsideredAsReplaced() || hasOverflowClip() || isHR() ||
4763 isLegend() || isWritingModeRoot() || isFlexItemIncludingDeprecated() || 4763 isLegend() || isWritingModeRoot() || isFlexItemIncludingDeprecated() ||
4764 style()->getColumnSpan() == ColumnSpanAll ||
4764 style()->containsPaint() || style()->containsLayout() || 4765 style()->containsPaint() || style()->containsLayout() ||
4765 style()->display() == EDisplay::kFlowRoot; 4766 style()->display() == EDisplay::kFlowRoot;
4766 } 4767 }
4767 4768
4768 bool LayoutBox::hasNonCompositedScrollbars() const { 4769 bool LayoutBox::hasNonCompositedScrollbars() const {
4769 if (PaintLayerScrollableArea* scrollableArea = this->getScrollableArea()) { 4770 if (PaintLayerScrollableArea* scrollableArea = this->getScrollableArea()) {
4770 if (scrollableArea->hasHorizontalScrollbar() && 4771 if (scrollableArea->hasHorizontalScrollbar() &&
4771 !scrollableArea->layerForHorizontalScrollbar()) 4772 !scrollableArea->layerForHorizontalScrollbar())
4772 return true; 4773 return true;
4773 if (scrollableArea->hasVerticalScrollbar() && 4774 if (scrollableArea->hasVerticalScrollbar() &&
(...skipping 981 matching lines...) Expand 10 before | Expand all | Expand 10 after
5755 5756
5756 void LayoutBox::MutableForPainting:: 5757 void LayoutBox::MutableForPainting::
5757 savePreviousContentBoxSizeAndLayoutOverflowRect() { 5758 savePreviousContentBoxSizeAndLayoutOverflowRect() {
5758 auto& rareData = layoutBox().ensureRareData(); 5759 auto& rareData = layoutBox().ensureRareData();
5759 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true; 5760 rareData.m_hasPreviousContentBoxSizeAndLayoutOverflowRect = true;
5760 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size(); 5761 rareData.m_previousContentBoxSize = layoutBox().contentBoxRect().size();
5761 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect(); 5762 rareData.m_previousLayoutOverflowRect = layoutBox().layoutOverflowRect();
5762 } 5763 }
5763 5764
5764 } // namespace blink 5765 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698