third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2799363003: A column-span:all element should always establish a new formatting context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2799363003: A column-span:all element should always establish a new formatting context. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 3a4b357cc158a3f7e9f11cccc08596cf41dab721..52a3830a16982f9665d744375e5c3a2d7febe190 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -559,7 +559,8 @@ bool LayoutBlock::createsNewFormattingContext() const {

hasOverflowClip() || isFlexItemIncludingDeprecated() ||

style()->specifiesColumns() || isLayoutFlowThread() || isTableCell() ||

isTableCaption() || isFieldset() || isWritingModeRoot() ||

- isDocumentElement() || isColumnSpanAll() || isGridItem() ||

+ isDocumentElement() || isGridItem() ||

+ style()->getColumnSpan() == ColumnSpanAll ||

style()->containsPaint() || style()->containsLayout() ||

isSVGForeignObject() || style()->display() == EDisplay::kFlowRoot;

}