chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc - Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)

Patch Set: Updates and address Ojan's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc ('k') | chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc » ('j') | chrome/browser/page_load_metrics/page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

index c74e1b8e54cb7b58a5c70abd5f581f74a8f8b420..64ea0ba8714e5edbde3db9e9f9472f5eb94d35a1 100644

--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

@@ -139,8 +139,9 @@ void PageLoadMetricsObserverTestHarness::SimulateTimingAndMetadataUpdate(

void PageLoadMetricsObserverTestHarness::SimulateLoadedResource(

const ExtraRequestInfo& info) {

observer_->OnRequestComplete(

- content::GlobalRequestID(), content::RESOURCE_TYPE_SCRIPT,

- info.was_cached, info.data_reduction_proxy_used, info.raw_body_bytes,

+ info.url, info.frame_tree_node_id, content::GlobalRequestID(),

+ content::RESOURCE_TYPE_SCRIPT, info.was_cached,

+ info.data_reduction_proxy_used, info.raw_body_bytes,

info.original_network_content_length, base::TimeTicks::Now());

}