Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4458)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Updates and address Ojan's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
index 49cb3dce8956f8f776e1423c1960e60de5c70d9e..0b6cd1b2906321c2f38a369540abfd7a46db78a6 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
@@ -142,10 +142,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, Basic) {
TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
NavigateAndCommit(GURL(kDefaultTestUrl));
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used */,
+ 0 /* original_network_content_length */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -154,12 +154,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
blink::WebLoadingBehaviorFlag::WebLoadingBehaviorSubresourceFilterMatch;
SimulateTimingAndMetadataUpdate(timing, metadata);
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used */,
+ 0 /* original_network_content_length */});
- SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
+ SimulateLoadedResource({GURL(), -1 /* frame_tree_node_id */,
+ true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
false /* data_reduction_proxy_used */,
0 /* original_network_content_length */});
@@ -237,10 +238,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
SimulateMediaPlayed();
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used */,
+ 0 /* original_network_content_length */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -249,12 +250,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
blink::WebLoadingBehaviorFlag::WebLoadingBehaviorSubresourceFilterMatch;
SimulateTimingAndMetadataUpdate(timing, metadata);
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used */,
- 0 /* original_network_content_length */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used */,
+ 0 /* original_network_content_length */});
- SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
+ SimulateLoadedResource({GURL(), -1 /* frame_tree_node_id */,
+ true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
false /* data_reduction_proxy_used */,
0 /* original_network_content_length */});

Powered by Google App Engine
This is Rietveld 408576698