Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6639)

Unified Diff: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Updates and address Ojan's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
index d8e9e8c574e435a4ba2b7654605ef6323a254bf5..f531aa29a9bb7979a3babbf71efe1f4b6842f471 100644
--- a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
@@ -55,20 +55,20 @@ class MediaPageLoadMetricsObserverTest
// Prepare 4 resources of varying size and configurations.
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
0 /* original_network_content_length */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
// Uncached proxied request with .1 compression ratio.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
// Uncached proxied request with .5 compression ratio.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
};

Powered by Google App Engine
This is Rietveld 408576698