[PageLoadMetrics] Keep track of Ad Sizes on Pages

chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index f3fa5d03ba0a44dffa7c175406b0bab005279369..eb132e44666b0bbc9f3207571acfd99baa8eeb8c 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -54,11 +54,15 @@ PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(
       page_load_metrics::PageLoadMetadata());
 }
 
-ExtraRequestInfo::ExtraRequestInfo(bool was_cached,
+ExtraRequestInfo::ExtraRequestInfo(const GURL& url,
+                                   int frame_tree_node_id,
+                                   bool was_cached,
                                    int64_t raw_body_bytes,
                                    bool data_reduction_proxy_used,
                                    int64_t original_network_content_length)
-    : was_cached(was_cached),
+    : url(url),

[Charlie Harrison, 2017/04/10 18:39:42]

I really dislike doing an extra URL copy here... Are GURLs still not
move()-able?

[jkarlin, 2017/04/11 16:46:28]

Done.

[jkarlin, 2017/04/13 17:25:30]

Undone. It added too much complexity. For one thing the caller was taking a
const GURL& and std::moving it (a mistake on my part), which results in a copy
and no compiler warning.

Next, the top of the call stack, NotifyUIThreadOfRequestComplete, takes the url
as a const GURL& from Bind. std::moving that GURL results in a copy anyway. So
we don't actually reduce the number of copies and then everyone has to be more
careful about using the object after it has been std::moved.

+      frame_tree_node_id(frame_tree_node_id),
+      was_cached(was_cached),
       raw_body_bytes(raw_body_bytes),
       data_reduction_proxy_used(data_reduction_proxy_used),
       original_network_content_length(original_network_content_length) {}
@@ -90,6 +94,12 @@ PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit(
   return CONTINUE_OBSERVING;
 }
 
+PageLoadMetricsObserver::ObservePolicy
+PageLoadMetricsObserver::OnCommitSubFrame(
+    content::NavigationHandle* navigation_handle) {
+  return CONTINUE_OBSERVING;
+}
+
 PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
     const PageLoadTiming& timing,
     const PageLoadExtraInfo& extra_info) {