Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2798923003: [Sensors] Update exceptions throwing from OrientationSensor.populateMatrix() (Closed)

Created:
3 years, 8 months ago by Mikhail
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews, haraken, wanming.lin, shalamov, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Update exceptions throwing from OrientationSensor.populateMatrix() The updated OrientationSensor.populateMatrix() algorithm[1] does not check sensor's state, it checks only whether the reading data are present. BUG=661478 [1] https://w3c.github.io/orientation-sensor/#orientationsensor-populatematrix Review-Url: https://codereview.chromium.org/2798923003 Cr-Commit-Position: refs/heads/master@{#462835} Committed: https://chromium.googlesource.com/chromium/src/+/e60fc7f9d9c594d84422ebfc796abca4a70459ab

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments from Alex #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/OrientationSensor.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Mikhail
PTAL
3 years, 8 months ago (2017-04-06 11:48:21 UTC) #5
shalamov
lgtm with nits https://codereview.chromium.org/2798923003/diff/1/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html File third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html (right): https://codereview.chromium.org/2798923003/diff/1/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html#newcode48 third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html:48: // Throws at wrong sensor state. ...
3 years, 8 months ago (2017-04-06 13:57:55 UTC) #8
Reilly Grant (use Gerrit)
lgtm % shalamov's nit
3 years, 8 months ago (2017-04-06 17:27:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798923003/20001
3 years, 8 months ago (2017-04-07 08:10:42 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 11:18:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e60fc7f9d9c594d84422ebfc796a...

Powered by Google App Engine
This is Rietveld 408576698