third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html - Issue 2798923003: [Sensors] Update exceptions throwing from OrientationSensor.populateMatrix()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html

Issue 2798923003: [Sensors] Update exceptions throwing from OrientationSensor.populateMatrix() (Closed)

Patch Set: Comments from Alex Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html

diff --git a/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html b/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html

index c11f7252b2ec09b874125f76d455bc5a943ced07..c8aa8b09db3b45d0e3bae12c7794a7f0aad79b1e 100644

--- a/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html

+++ b/third_party/WebKit/LayoutTests/sensor/absolute-orientation-sensor.html

@@ -45,8 +45,8 @@ sensor_test(sensor => {

// Throws with insufficient buffer space.

assert_throws({ name: 'TypeError' }, () => sensorObject.populateMatrix(new Float32Array(15)));

- // Throws at wrong sensor state.

- assert_throws({ name: 'InvalidStateError' }, () => sensorObject.populateMatrix(new Float32Array(16)));

+ // Throws if no orientation data available.

+ assert_throws({ name: 'NotReadableError' }, () => sensorObject.populateMatrix(new Float32Array(16)));

sensorObject.start();

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/sensor/OrientationSensor.cpp » ('j') | no next file with comments »