Chromium Code Reviews Chromium Code Reviews
Issue 2798923003:
[Sensors] Update exceptions throwing from OrientationSensor.populateMatrix() (Closed)
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <script src="../resources/testharness.js"></script> | 2 <script src="../resources/testharness.js"></script> |
| 3 <script src="../resources/testharnessreport.js"></script> | 3 <script src="../resources/testharnessreport.js"></script> |
| 4 <script src="../resources/mojo-helpers.js"></script> | 4 <script src="../resources/mojo-helpers.js"></script> |
| 5 <script src="resources/sensor-helpers.js"></script> | 5 <script src="resources/sensor-helpers.js"></script> |
| 6 <script src="resources/generic-sensor-tests.js"></script> | 6 <script src="resources/generic-sensor-tests.js"></script> |
| 7 <script> | 7 <script> |
| 8 | 8 |
| 9 'use strict'; | 9 'use strict'; |
| 10 | 10 |
| (...skipping 27 matching lines...) Expand all Loading... | |
| 38 } | 38 } |
| 39 | 39 |
| 40 runGenericSensorTests(AbsoluteOrientationSensor, update_sensor_reading, verify_s ensor_reading); | 40 runGenericSensorTests(AbsoluteOrientationSensor, update_sensor_reading, verify_s ensor_reading); |
| 41 | 41 |
| 42 sensor_test(sensor => { | 42 sensor_test(sensor => { |
| 43 let sensorObject = new AbsoluteOrientationSensor(); | 43 let sensorObject = new AbsoluteOrientationSensor(); |
| 44 | 44 |
| 45 // Throws with insufficient buffer space. | 45 // Throws with insufficient buffer space. |
| 46 assert_throws({ name: 'TypeError' }, () => sensorObject.populateMatrix(new Flo at32Array(15))); | 46 assert_throws({ name: 'TypeError' }, () => sensorObject.populateMatrix(new Flo at32Array(15))); |
| 47 | 47 |
| 48 // Throws at wrong sensor state. | 48 // Throws at wrong sensor state. |
|
shalamov
2017/04/06 13:57:55
Update comment?
| |
| 49 assert_throws({ name: 'InvalidStateError' }, () => sensorObject.populateMatrix (new Float32Array(16))); | 49 assert_throws({ name: 'NotReadableError' }, () => sensorObject.populateMatrix( new Float32Array(16))); |
| 50 | 50 |
| 51 sensorObject.start(); | 51 sensorObject.start(); |
| 52 | 52 |
| 53 return sensor.mockSensorProvider.getCreatedSensor() | 53 return sensor.mockSensorProvider.getCreatedSensor() |
| 54 .then(mockSensor => { | 54 .then(mockSensor => { |
| 55 return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading); | 55 return mockSensor.setUpdateSensorReadingFunction(update_sensor_reading); |
| 56 }) | 56 }) |
| 57 .then(mockSensor => { | 57 .then(mockSensor => { |
| 58 return new Promise((resolve, reject) => { | 58 return new Promise((resolve, reject) => { |
| 59 let wrapper = new CallbackWrapper(() => { | 59 let wrapper = new CallbackWrapper(() => { |
| (...skipping 20 matching lines...) Expand all Loading... | |
| 80 }, reject); | 80 }, reject); |
| 81 | 81 |
| 82 sensorObject.onchange = wrapper.callback; | 82 sensorObject.onchange = wrapper.callback; |
| 83 sensorObject.onerror = reject; | 83 sensorObject.onerror = reject; |
| 84 }); | 84 }); |
| 85 }) | 85 }) |
| 86 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); }); | 86 .then(mockSensor => { return mockSensor.removeConfigurationCalled(); }); |
| 87 }, 'Test AbsoluteOrientationSensor.populateMatrix() method works correctly.'); | 87 }, 'Test AbsoluteOrientationSensor.populateMatrix() method works correctly.'); |
| 88 | 88 |
| 89 </script> | 89 </script> |
| OLD | NEW |
