[Doodle] Allow overriding the API URL via a fieldtrial param

[Doodle] Allow overriding the API URL via a fieldtrial param

This also adds choices in about:flags to test the various Doodle types.

BUG=690467
Review-Url: https://codereview.chromium.org/2798033002
Cr-Commit-Position: refs/heads/master@{#462103}
Committed: https://chromium.googlesource.com/chromium/src/+/c18a893645532202d554f5c9ea20b68487372397

[Marc Treib, 2017-04-05 13:56:58]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 13:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 13:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 13:59:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Marc Treib, 2017-04-05 14:10:30]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 14:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 15:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 15:04:21]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-04-05 15:13:42]

treib@chromium.org changed reviewers:
+ sfiera@chromium.org

[Marc Treib, 2017-04-05 15:13:42]

PTAL!
(Normally I'd send this to fhorschig or bauerb, but since they're both out...
congratulations! ;) )

[sfiera, 2017-04-05 15:22:13]

LGTM

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2555: {"use-new-doodle-api",
flag_descriptions::kUseNewDoodleApiName,
So this flag doesn't exist on Desktop, even though the new Doodle code is
intended for use there too?

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2559: "UseNewDoodleApi")},
kUseNewDoodleApi.name?

[Marc Treib, 2017-04-05 15:33:59]

Thanks!

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2555: {"use-new-doodle-api",
flag_descriptions::kUseNewDoodleApiName,
On 2017/04/05 15:22:13, sfiera wrote:
> So this flag doesn't exist on Desktop, even though the new Doodle code is
> intended for use there too?

Eventually, but not yet.
When we start working on desktop, the flag will have to be moved. In retrospect,
it might have been better to create it in a common location in the first place.

https://codereview.chromium.org/2798033002/diff/20001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:2559: "UseNewDoodleApi")},
On 2017/04/05 15:22:13, sfiera wrote:
> kUseNewDoodleApi.name?

Done.

[Marc Treib, 2017-04-05 15:34:36]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 15:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-04-05 16:12:42]

The CQ bit was unchecked by treib@chromium.org

[Marc Treib, 2017-04-05 16:12:43]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2017-04-05 16:12:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sfiera@chromium.org
Link to the patchset: https://codereview.chromium.org/2798033002/#ps40001
(title: ".name")

[commit-bot: I haz the power, 2017-04-05 16:12:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 16:25:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491408763025570,
"parent_rev": "073e4d7067e7af90e5faa0ef4adb19f3e8e4ded4", "commit_rev":
"c18a893645532202d554f5c9ea20b68487372397"}

[commit-bot: I haz the power, 2017-04-05 16:26:38]

Description was changed from

==========
[Doodle] Allow overriding the API URL via a fieldtrial param

This also adds choices in about:flags to test the various Doodle types.

BUG=690467
==========

to

==========
[Doodle] Allow overriding the API URL via a fieldtrial param

This also adds choices in about:flags to test the various Doodle types.

BUG=690467

Review-Url: https://codereview.chromium.org/2798033002
Cr-Commit-Position: refs/heads/master@{#462103}
Committed:
https://chromium.googlesource.com/chromium/src/+/c18a893645532202d554f5c9ea20...
==========

[commit-bot: I haz the power, 2017-04-05 16:26:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c18a893645532202d554f5c9ea20...