Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: chrome/browser/about_flags.cc

Issue 2798033002: [Doodle] Allow overriding the API URL via a fieldtrial param (Closed)
Patch Set: .name Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/doodle/doodle_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index d1d8ace65391c7f5c9940ad3922506eb69165f06..495a80a66b444b4796c3958ec8e4e6af84523c1b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -753,6 +753,56 @@ const FeatureEntry::FeatureVariation
arraysize(kAutofillCreditCardLastUsedDateFeatureVariationExpDate),
nullptr}};
+#if defined(OS_ANDROID)
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest0[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android0.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest1[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android1.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest2[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android2.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest3[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android3.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest4[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android4.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest5[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android5.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest6[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android6.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest7[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android7.json"}};
+const FeatureEntry::FeatureParam kUseNewDoodleApiTest8[] = {
+ {"doodle_override_url",
+ "https://www.gstatic.com/chrome/ntp/doodle_test/android8.json"}};
+
+const FeatureEntry::FeatureVariation kUseNewDoodleApiVariations[] = {
+ {"(force test doodle 0)", kUseNewDoodleApiTest0,
+ arraysize(kUseNewDoodleApiTest0), nullptr},
+ {"(force test doodle 1)", kUseNewDoodleApiTest1,
+ arraysize(kUseNewDoodleApiTest1), nullptr},
+ {"(force test doodle 2)", kUseNewDoodleApiTest2,
+ arraysize(kUseNewDoodleApiTest2), nullptr},
+ {"(force test doodle 3)", kUseNewDoodleApiTest3,
+ arraysize(kUseNewDoodleApiTest3), nullptr},
+ {"(force test doodle 4)", kUseNewDoodleApiTest4,
+ arraysize(kUseNewDoodleApiTest4), nullptr},
+ {"(force test doodle 5)", kUseNewDoodleApiTest5,
+ arraysize(kUseNewDoodleApiTest5), nullptr},
+ {"(force test doodle 6)", kUseNewDoodleApiTest6,
+ arraysize(kUseNewDoodleApiTest6), nullptr},
+ {"(force test doodle 7)", kUseNewDoodleApiTest7,
+ arraysize(kUseNewDoodleApiTest7), nullptr},
+ {"(force test doodle 8)", kUseNewDoodleApiTest8,
+ arraysize(kUseNewDoodleApiTest8), nullptr}};
+#endif // OS_ANDROID
+
const FeatureEntry::FeatureParam kDelayNavigation5SecondDelay[] = {
{DelayNavigationThrottle::kParamDelayNavigationDurationMillis, "5000"},
{DelayNavigationThrottle::kParamDelayNavigationProbability, "1"}};
@@ -2504,7 +2554,9 @@ const FeatureEntry kFeatureEntries[] = {
#if defined(OS_ANDROID)
{"use-new-doodle-api", flag_descriptions::kUseNewDoodleApiName,
flag_descriptions::kUseNewDoodleApiDescription, kOsAndroid,
- FEATURE_VALUE_TYPE(chrome::android::kUseNewDoodleApi)},
+ FEATURE_WITH_PARAMS_VALUE_TYPE(chrome::android::kUseNewDoodleApi,
+ kUseNewDoodleApiVariations,
+ chrome::android::kUseNewDoodleApi.name)},
#endif // OS_ANDROID
{"delay-navigation", flag_descriptions::kDelayNavigationName,
« no previous file with comments | « no previous file | chrome/browser/doodle/doodle_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698