Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: components/doodle/doodle_fetcher_impl_unittest.cc

Issue 2798033002: [Doodle] Allow overriding the API URL via a fieldtrial param (Closed)
Patch Set: .name Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/doodle/doodle_fetcher_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/doodle/doodle_fetcher_impl_unittest.cc
diff --git a/components/doodle/doodle_fetcher_impl_unittest.cc b/components/doodle/doodle_fetcher_impl_unittest.cc
index 813557a62cbb561550c7359647e45a8008b07331..8bdb1fb126ccd2f429a24ef050bdcf323a41c069 100644
--- a/components/doodle/doodle_fetcher_impl_unittest.cc
+++ b/components/doodle/doodle_fetcher_impl_unittest.cc
@@ -70,14 +70,16 @@ void ParseJson(
class DoodleFetcherImplTestBase : public testing::Test {
public:
- DoodleFetcherImplTestBase(bool gray_background)
+ DoodleFetcherImplTestBase(bool gray_background,
+ const base::Optional<std::string>& override_url)
: google_url_tracker_(base::MakeUnique<GoogleURLTrackerClientStub>(),
GoogleURLTracker::UNIT_TEST_MODE),
doodle_fetcher_(
new net::TestURLRequestContextGetter(message_loop_.task_runner()),
&google_url_tracker_,
base::Bind(ParseJson),
- gray_background) {}
+ gray_background,
+ override_url) {}
void RespondWithData(const std::string& data) {
net::TestURLFetcher* url_fetcher = GetRunningFetcher();
@@ -121,7 +123,8 @@ class DoodleFetcherImplTestBase : public testing::Test {
class DoodleFetcherImplTest : public DoodleFetcherImplTestBase {
public:
DoodleFetcherImplTest()
- : DoodleFetcherImplTestBase(/*gray_background=*/true) {}
+ : DoodleFetcherImplTestBase(/*gray_background=*/true,
+ /*override_url=*/base::nullopt) {}
};
TEST_F(DoodleFetcherImplTest, ReturnsFromFetchWithoutError) {
@@ -422,7 +425,8 @@ TEST_F(DoodleFetcherImplTest, OverridesBaseUrlWithCommandLineArgument) {
class DoodleFetcherImplNoGrayBgTest : public DoodleFetcherImplTestBase {
public:
DoodleFetcherImplNoGrayBgTest()
- : DoodleFetcherImplTestBase(/*gray_background=*/false) {}
+ : DoodleFetcherImplTestBase(/*gray_background=*/false,
+ /*override_url=*/base::nullopt) {}
};
TEST_F(DoodleFetcherImplNoGrayBgTest, PassesNoGrayBgParam) {
@@ -433,4 +437,36 @@ TEST_F(DoodleFetcherImplNoGrayBgTest, PassesNoGrayBgParam) {
Eq(Resolve(kDoodleConfigPathNoGrayBg)));
}
+class DoodleFetcherImplRelativeOverrideUrlTest
+ : public DoodleFetcherImplTestBase {
+ public:
+ DoodleFetcherImplRelativeOverrideUrlTest()
+ : DoodleFetcherImplTestBase(/*gray_background=*/false,
+ /*override_url=*/std::string("/different")) {}
+};
+
+TEST_F(DoodleFetcherImplRelativeOverrideUrlTest, OverridesWithRelativeUrl) {
+ base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback;
+ doodle_fetcher()->FetchDoodle(callback.Get());
+
+ EXPECT_THAT(GetRunningFetcher()->GetOriginalURL(), Eq(Resolve("/different")));
+}
+
+class DoodleFetcherImplAbsoluteOverrideUrlTest
+ : public DoodleFetcherImplTestBase {
+ public:
+ DoodleFetcherImplAbsoluteOverrideUrlTest()
+ : DoodleFetcherImplTestBase(
+ /*gray_background=*/false,
+ /*override_url=*/std::string("http://host.com/ddl")) {}
+};
+
+TEST_F(DoodleFetcherImplAbsoluteOverrideUrlTest, OverridesWithAbsoluteUrl) {
+ base::MockCallback<DoodleFetcherImpl::FinishedCallback> callback;
+ doodle_fetcher()->FetchDoodle(callback.Get());
+
+ EXPECT_THAT(GetRunningFetcher()->GetOriginalURL(),
+ Eq(GURL("http://host.com/ddl")));
+}
+
} // namespace doodle
« no previous file with comments | « components/doodle/doodle_fetcher_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698