Generate ComputedStyle::hasViewportUnits and hasRemUnits.

third_party/WebKit/Source/build/scripts/make_computed_style_base.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import math
 import sys
 
 import json5_generator
 import template_expander
@@ skipping 32 matching lines @@
     {'name': 'AffectedByActive', 'field_template': 'monotonic_flag',
      'inherited': False, 'independent': False, 'default_value': False},
     {'name': 'AffectedByDrag', 'field_template': 'monotonic_flag',
      'inherited': False, 'independent': False, 'default_value': False},
     # A non-inherited property references a variable or @apply is used
     {'name': 'HasVariableReferenceFromNonInheritedProperty', 'field_template': 'monotonic_flag',
      'inherited': False, 'independent': False, 'default_value': False},
     # Explicitly inherits a non-inherited property
     {'name': 'HasExplicitlyInheritedProperties', 'field_template': 'monotonic_flag',
      'inherited': False, 'independent': False, 'default_value': False},
+    # These are set if we used viewport or rem units when resolving a length.
+    # TODO(shend): HasViewportUnits should be a monotonic_flag.
+    {'name': 'HasViewportUnits', 'field_template': 'flag', 'default_value': 'false',

[nainar, 2017/04/05 16:41:49]

why isnt it a monotonic flag for my own understanding?

[shend, 2017/04/05 22:32:36]

Good question. setHasViewportUnits currently takes a boolean argument because of
a hack discussed in https://codereview.chromium.org/2767853002. I'll update the
CL description.

[alancutter (OOO until 2018), 2017/04/06 04:18:49]

I don't think this "hack" is the reason it's not a monotonic_flag. The reason is
because some places sets it false. Also your updated description has the two
fields backwards in this regard.

+     'inherited': False, 'independent': False},
+    {'name': 'HasRemUnits', 'field_template': 'monotonic_flag', 'default_value': 'false',
+     'inherited': False, 'independent': False},
     # These properties only have generated storage, and their methods are handwritten in ComputedStyle.
     # TODO(shend): Remove these fields and delete the 'storage_only' template.
     {'name': 'EmptyState', 'field_template': 'storage_only', 'size': 1, 'default_value': 'false',
      'type_name': 'bool', 'inherited': False, 'independent': False},
     {'name': 'StyleType', 'field_template': 'storage_only', 'size': 6, 'default_value': '0',
      'type_name': 'PseudoId', 'inherited': False, 'independent': False},
     {'name': 'PseudoBits', 'field_template': 'storage_only', 'size': 8, 'default_value': 'PseudoIdNone',
      'type_name': 'PseudoId', 'inherited': False, 'independent': False},
     # True if 'underline solid' is the only text decoration on this element.
     {'name': 'HasSimpleUnderline', 'field_template': 'storage_only', 'size': 1, 'default_value': 'false',
@@ skipping 324 matching lines @@
                     'mapping': [(enum_value_name(k), enum_for_css_keyword(k)) for k in property_['keywords']],
                 }
 
         return {
             'include_paths': self._include_paths,
             'mappings': mappings,
         }
 
 if __name__ == '__main__':
     json5_generator.Maker(ComputedStyleBaseWriter).main()