Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2828193002: DO NOT LAND!! Revert of Generate ComputedStyle::hasViewportUnits and hasRemUnits. (Closed)

Created:
3 years, 8 months ago by shend
Modified:
3 years, 8 months ago
Reviewers:
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT LAND!! Revert of Generate ComputedStyle::hasViewportUnits and hasRemUnits. (patchset #4 id:60001 of https://codereview.chromium.org/2797963002/ ) Reason for revert: testing https://bugs.chromium.org/p/chromium/issues/detail?id=713128 Original issue's description: > Generate ComputedStyle::hasViewportUnits and hasRemUnits. > > This patch moves hasViewportUnits and hasRemUnits to be generated in > ComputedStyleBase. Both are noninherited nonproperties. > > hasRemUnits is generated as a monotonic_flag field, but > hasViewportUnits needs to be a boolean flag field because there are > places where it gets set to false. > > Since these are the two remaining noninherited fields stored directly > in ComputedStyle, this patch also removes the NonInheritedData struct > from ComputedStyle. > > Diff of generated files: > https://gist.github.com/47fd74b4a54917d0413367227dcb962a/revisions > > BUG=628043 > > Review-Url: https://codereview.chromium.org/2797963002 > Cr-Commit-Position: refs/heads/master@{#462377} > Committed: https://chromium.googlesource.com/chromium/src/+/25809e1270b9eb4103f1efcc089c781df8465e39 TBR=alancutter@chromium.org,nainar@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=628043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -23 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +52 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
shend
3 years, 8 months ago (2017-04-20 06:37:30 UTC) #1
Created Revert of Generate ComputedStyle::hasViewportUnits and hasRemUnits.

Powered by Google App Engine
This is Rietveld 408576698