Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Issue 2797373003: Milo: Fix logdog links (Closed)

Created:
3 years, 8 months ago by Ryan Tseng
Modified:
3 years, 8 months ago
Reviewers:
dnj, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Invert logic instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M milo/appengine/buildbot/build.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
hinoka
3 years, 8 months ago (2017-04-06 21:32:49 UTC) #4
hinoka
ptal, see: https://1652-3480eff-tainted-hinoka-dot-luci-milo-dev.appspot.com/buildbot/chromium.perf/Win%207%20x64%20Perf/565
3 years, 8 months ago (2017-04-06 21:33:05 UTC) #5
hinoka
PS2 just inverts the isLog logic
3 years, 8 months ago (2017-04-06 21:50:35 UTC) #10
dnj
lgtm
3 years, 8 months ago (2017-04-06 21:51:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797373003/10002
3 years, 8 months ago (2017-04-06 21:52:34 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:58:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:10002) as
https://github.com/luci/luci-go/commit/afac4f28a475757e790a3b03d5b0e0eb87d38c17

Powered by Google App Engine
This is Rietveld 408576698