Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: milo/appengine/buildbot/build.go

Issue 2797373003: Milo: Fix logdog links (Closed)
Patch Set: Invert logic instead Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The LUCI Authors. All rights reserved. 1 // Copyright 2016 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package buildbot 5 package buildbot
6 6
7 import ( 7 import (
8 "encoding/json" 8 "encoding/json"
9 "errors" 9 "errors"
10 "fmt" 10 "fmt"
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 // We have chosen to promote the aliases. Therefore, we will not include 600 // We have chosen to promote the aliases. Therefore, we will not include
601 // them as aliases in the modified step. 601 // them as aliases in the modified step.
602 remainingAliases.Del(sl.label) 602 remainingAliases.Del(sl.label)
603 603
604 result := make([]*stepLog, len(aliases)) 604 result := make([]*stepLog, len(aliases))
605 for i, alias := range aliases { 605 for i, alias := range aliases {
606 aliasStepLog := stepLog{alias.Text, alias.URL} 606 aliasStepLog := stepLog{alias.Text, alias.URL}
607 607
608 // Any link named "logdog" (Annotee cosmetic implementat ion detail) will 608 // Any link named "logdog" (Annotee cosmetic implementat ion detail) will
609 // inherit the name of the original log. 609 // inherit the name of the original log.
610 » » » if !isLog { 610 » » » if isLog {
611 if aliasStepLog.label == "logdog" { 611 if aliasStepLog.label == "logdog" {
612 aliasStepLog.label = sl.label 612 aliasStepLog.label = sl.label
613 } 613 }
614 } 614 }
615 615
616 result[i] = &aliasStepLog 616 result[i] = &aliasStepLog
617 } 617 }
618 618
619 // If we performed mapping, add the OLD -> NEW URL mapping to li nkMap. 619 // If we performed mapping, add the OLD -> NEW URL mapping to li nkMap.
620 // 620 //
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 var newAliases map[string][]*buildbotLinkAlias 659 var newAliases map[string][]*buildbotLinkAlias
660 if l := remainingAliases.Len(); l > 0 { 660 if l := remainingAliases.Len(); l > 0 {
661 newAliases = make(map[string][]*buildbotLinkAlias, l) 661 newAliases = make(map[string][]*buildbotLinkAlias, l)
662 remainingAliases.Iter(func(v string) bool { 662 remainingAliases.Iter(func(v string) bool {
663 newAliases[v] = s.Aliases[v] 663 newAliases[v] = s.Aliases[v]
664 return true 664 return true
665 }) 665 })
666 } 666 }
667 s.Aliases = newAliases 667 s.Aliases = newAliases
668 } 668 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698