milo/appengine/buildbot/build.go - Issue 2797373003: Milo: Fix logdog links

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/build.go

Issue 2797373003: Milo: Fix logdog links (Closed)

Patch Set: Invert logic instead Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/build.go

diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go

index b34a9202dbe3eeb3dd975448e160e87ce97b7f61..289b53592dbd5f3146e9d0fa95120449cf5a1416 100644

--- a/milo/appengine/buildbot/build.go

+++ b/milo/appengine/buildbot/build.go

@@ -607,7 +607,7 @@ func promoteLogDogLinks(s *buildbotStep, isInitialStep bool, linkMap map[string]

// Any link named "logdog" (Annotee cosmetic implementation detail) will

// inherit the name of the original log.

- if !isLog {

+ if isLog {

if aliasStepLog.label == "logdog" {

aliasStepLog.label = sl.label

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »