Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Issue 2797343002: Get rid of the base_paths target. (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of the base_paths target. Fold the sources back into the base target. There's no good reason to have a separate target to limit visiblity to :base. BUG=686208, 706698 Review-Url: https://codereview.chromium.org/2797343002 Cr-Commit-Position: refs/heads/master@{#462265} Committed: https://chromium.googlesource.com/chromium/src/+/2a567808f0a58c27d84845c8c178f33e79a1426b

Patch Set 1 #

Patch Set 2 : add is_linux #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -30 lines) Patch
M base/BUILD.gn View 1 3 chunks +18 lines, -30 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
erikchen
brettw: Please review.
3 years, 8 months ago (2017-04-05 21:09:28 UTC) #2
brettw
lgtm
3 years, 8 months ago (2017-04-05 22:01:10 UTC) #7
Wez
Can we include BUG=686208,706698 in the CL description, since those were the bugs relating to ...
3 years, 8 months ago (2017-04-05 22:09:20 UTC) #10
erikchen
On 2017/04/05 22:09:20, Wez wrote: > Can we include BUG=686208,706698 in the CL description, since ...
3 years, 8 months ago (2017-04-05 22:11:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797343002/20001
3 years, 8 months ago (2017-04-05 22:12:01 UTC) #14
Wez
https://codereview.chromium.org/2797343002/diff/20001/base/BUILD.gn File base/BUILD.gn (right): https://codereview.chromium.org/2797343002/diff/20001/base/BUILD.gn#newcode1622 base/BUILD.gn:1622: allow_circular_includes_from = public_deps As discussed, this GN check hint ...
3 years, 8 months ago (2017-04-05 22:18:25 UTC) #15
erikchen
On 2017/04/05 22:18:25, Wez wrote: > https://codereview.chromium.org/2797343002/diff/20001/base/BUILD.gn > File base/BUILD.gn (right): > > https://codereview.chromium.org/2797343002/diff/20001/base/BUILD.gn#newcode1622 > ...
3 years, 8 months ago (2017-04-05 22:21:19 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 23:21:57 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a567808f0a58c27d84845c8c178...

Powered by Google App Engine
This is Rietveld 408576698