Get rid of the base_paths target.

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # HOW TO WRITE CONDITIONALS IN THIS FILE
 # ======================================
 #
 # In many other places, one would write a conditional that expresses all the
 # cases when a source file is used or unused, and then either add or subtract
 # it from the sources list in that case
@@ skipping 69 matching lines @@
 if (is_nacl_nonsfi) {
   # Must be in a config because of how GN orders flags (otherwise -Wall will
   # appear after this, and turn it back on).
   config("nacl_nonsfi_warnings") {
     # file_util_posix.cc contains a function which is not
     # being used by nacl_helper_nonsfi.
     cflags = [ "-Wno-unused-function" ]
   }
 }
 
-if (is_nacl) {
-  # None of the files apply to nacl, and we can't make an empty static library.
-  group("base_paths") {
-  }
-} else {
-  static_library("base_paths") {
-    sources = [
-      "base_paths.cc",
-      "base_paths.h",
-      "base_paths_android.cc",
-      "base_paths_android.h",
-      "base_paths_mac.h",
-      "base_paths_mac.mm",
-      "base_paths_posix.cc",
-      "base_paths_posix.h",
-      "base_paths_win.cc",
-      "base_paths_win.h",
-    ]
-
-    if (is_android || is_mac || is_ios) {
-      sources -= [ "base_paths_posix.cc" ]
-    }
-
-    configs += [ ":base_implementation" ]
-
-    visibility = [ ":base" ]
-  }
-}
-
 if (is_android) {
   config("android_system_libs") {
     libs = [ "log" ]  # Used by logging.cc.
   }
 }
 
 # Base and everything it depends on should be a static library rather than
 # a source set. Base is more of a "library" in the classic sense in that many
 # small parts of it are used in many different contexts. This combined with a
 # few static initializers floating around means that dead code stripping
@@ skipping 978 matching lines @@
     "win/wait_chain.cc",
     "win/wait_chain.h",
     "win/win_util.cc",
     "win/win_util.h",
     "win/windows_version.cc",
     "win/windows_version.h",
     "win/wrapped_window_proc.cc",
     "win/wrapped_window_proc.h",
   ]
 
+  if (!is_nacl) {
+    sources += [
+      "base_paths.cc",
+      "base_paths.h",
+      "base_paths_android.cc",
+      "base_paths_android.h",
+      "base_paths_mac.h",
+      "base_paths_mac.mm",
+      "base_paths_posix.h",
+      "base_paths_win.cc",
+      "base_paths_win.h",
+    ]
+
+    if (is_linux) {
+      sources += [ "base_paths_posix.cc" ]
+    }
+  }
+
   all_dependent_configs = []
   defines = []
   data = []
 
   configs += [
     ":base_flags",
     ":base_implementation",
     "//base/allocator:allocator_shim_define",  # for allocator_check.cc.
     "//build/config:precompiled_headers",
   ]
 
   deps = [
     "//base/allocator",
     "//base/allocator:features",
     "//base/third_party/dynamic_annotations",
     "//third_party/modp_b64",
   ]
 
   public_deps = [
-    ":base_paths",
     ":base_static",
     ":build_date",
     ":debugging_flags",
   ]
 
   # Needed for <atomic> if using newer C++ library than sysroot
   if (!use_sysroot && (is_android || (is_linux && !is_chromecast))) {
     libs = [ "atomic" ]
   }
 
@@ skipping 477 matching lines @@
       data += [ "//third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer" ]
     }
   }
 
   configs += [ "//build/config/compiler:wexit_time_destructors" ]
   if (!is_debug) {
     configs -= [ "//build/config/compiler:default_optimization" ]
     configs += [ "//build/config/compiler:optimize_max" ]
   }
 
   allow_circular_includes_from = public_deps

[Wez, 2017/04/05 22:18:25]

As discussed, this GN check hint seems masked the fact that base_paths lacked
relevant dependencies - is there a path toward removing it?

If not then could GN be educated to build components in
allow_circular_includes_from only after all other deps & public_deps have been
built, to mitigate this case?

 }
 
 buildflag_header("debugging_flags") {
   header = "debugging_flags.h"
   header_dir = "base/debug"
   flags = [
     "ENABLE_PROFILING=$enable_profiling",
     "ENABLE_MEMORY_TASK_PROFILER=$enable_memory_task_profiler",
   ]
 }
@@ skipping 1055 matching lines @@
 }
 
 fuzzer_test("base_json_correctness_fuzzer") {
   sources = [
     "json/correctness_fuzzer.cc",
   ]
   deps = [
     ":base",
   ]
 }