Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2799123002: Remove allow_circular_includes_from from base/BUILD.gn (Closed)

Created:
3 years, 8 months ago by erikchen
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org, Wez
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove allow_circular_includes_from from base/BUILD.gn It was added to allow circular depdencies between the targets base_paths and base. The former no longer exists. BUG= Review-Url: https://codereview.chromium.org/2799123002 Cr-Commit-Position: refs/heads/master@{#462282} Committed: https://chromium.googlesource.com/chromium/src/+/9150fd8aa78ebf300a543a0b0d01f420229d355e

Patch Set 1 #

Patch Set 2 : Remove allow_circular_includes_from from base/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
erikchen
brettw: Please review.
3 years, 8 months ago (2017-04-05 22:36:05 UTC) #4
brettw
lgtm
3 years, 8 months ago (2017-04-05 23:15:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799123002/20001
3 years, 8 months ago (2017-04-05 23:30:08 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 00:01:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9150fd8aa78ebf300a543a0b0d01...

Powered by Google App Engine
This is Rietveld 408576698