Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.

Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584
R=gab@chromium.org
TBR=sky@chromium.org, vitalybuka@chromium.org

Review-Url: https://codereview.chromium.org/2797293002
Cr-Commit-Position: refs/heads/master@{#462492}
Committed: https://chromium.googlesource.com/chromium/src/+/0bc320f205ad411a7ab935fa79879ff75e8a7fc9

[fdoray, 2017-04-05 19:40:47]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2017-04-05 19:40:49]

gab@: PTAL

The change will then be TBRed to the owner.

[commit-bot: I haz the power, 2017-04-05 19:41:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 20:47:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:47:33]

Dry run: This issue passed the CQ dry run.

[gab, 2017-04-05 20:54:25]

lgtm

[Vitaly Buka (NO REVIEWS), 2017-04-05 20:56:40]

lgtm

[sky, 2017-04-05 23:19:35]

LGTM - be sure and remove any stale includes.

[fdoray, 2017-04-06 15:27:50]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2017-04-06 15:28:51]

On 2017/04/05 23:19:35, sky wrote:
> LGTM - be sure and remove any stale includes.

None of these files includes message_loop.h even though they used it, so no
includes to remove.

[commit-bot: I haz the power, 2017-04-06 15:46:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491492470830850, "parent_rev":
"01875e5e4b2740eb0579d959ac8c28019583d61c", "commit_rev":
"0bc320f205ad411a7ab935fa79879ff75e8a7fc9"}

[commit-bot: I haz the power, 2017-04-06 15:47:39]

Description was changed from

==========
Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=sky@chromium.org, vitalybuka@chromium.org
==========

to

==========
Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in every unit test that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3P...

BUG=708584
R=gab@chromium.org
TBR=sky@chromium.org, vitalybuka@chromium.org

Review-Url: https://codereview.chromium.org/2797293002
Cr-Commit-Position: refs/heads/master@{#462492}
Committed:
https://chromium.googlesource.com/chromium/src/+/0bc320f205ad411a7ab935fa7987...
==========

[commit-bot: I haz the power, 2017-04-06 15:47:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0bc320f205ad411a7ab935fa7987...

[fdoray, 2017-04-06 17:13:59]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2799743004/ by fdoray@chromium.org.

The reason for reverting is: Test timeout in
MutableProfileOAuth2TokenServiceDelegateTest.ShutdownService.