Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc

Issue 2797293002: Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc
diff --git a/chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc b/chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc
index ffe3a8823df2a390a6c9177403b17099e8dd05f9..bb5f88795a3be3df2990921fdb2c4a182c681ef9 100644
--- a/chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc
+++ b/chrome/browser/ui/desktop_ios_promotion/sms_service_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/desktop_ios_promotion/sms_service.h"
#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "components/signin/core/browser/account_tracker_service.h"
#include "components/signin/core/browser/fake_profile_oauth2_token_service.h"
#include "components/signin/core/browser/fake_signin_manager.h"
@@ -145,7 +146,7 @@ class SMSServiceTest : public testing::Test {
}
private:
- base::MessageLoop message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
FakeProfileOAuth2TokenService token_service_;
AccountTrackerService account_tracker_;
TestSigninClient signin_client_;

Powered by Google App Engine
This is Rietveld 408576698