chrome/browser/printing/cloud_print/privet_notifications_unittest.cc - Issue 2797293002: Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

Issue 2797293002: Use ScopedTaskEnvironment instead of MessageLoop in chrome unit tests. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/local_domain_resolver_unittest.cc ('k') | chrome/browser/process_singleton_posix_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc b/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

index 18249f8ef7d79d6c6f401800645e5902da9190fb..54d7ad0fd46cbe6180bf3e2ec19345d3c433548a 100644

--- a/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

+++ b/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

@@ -7,6 +7,7 @@

#include <memory>

#include "base/memory/ptr_util.h"

+#include "base/test/scoped_task_environment.h"

#include "base/threading/thread_task_runner_handle.h"

#include "chrome/browser/notifications/notification_test_util.h"

#include "chrome/browser/printing/cloud_print/privet_http_asynchronous_factory.h"

@@ -117,7 +118,7 @@ class PrivetNotificationsListenerTest : public testing::Test {

protected:

StrictMock<MockPrivetNotificationsListenerDeleagate> mock_delegate_;

std::unique_ptr<PrivetNotificationsListener> notification_listener_;

- base::MessageLoop message_loop_;

+ base::test::ScopedTaskEnvironment scoped_task_environment_;

scoped_refptr<net::TestURLRequestContextGetter> request_context_;

net::TestURLFetcherFactory fetcher_factory_;

DeviceDescription description_;