Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2797023002: Always identify test names that lead to failures (Closed)

Created:
3 years, 8 months ago by Paweł Hajdan Jr.
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : review #

Total comments: 4

Patch Set 3 : presubmit #

Patch Set 4 : proto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -18 lines) Patch
M recipe_engine/test.py View 1 3 chunks +11 lines, -6 lines 0 comments Download
M recipe_engine/test_result.proto View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M recipe_engine/test_result_pb2.py View 1 12 chunks +52 lines, -9 lines 0 comments Download
M unittests/test_test.py View 1 6 chunks +34 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
iannucci
lgtm w/ comments https://codereview.chromium.org/2797023002/diff/20001/recipe_engine/test_result.proto File recipe_engine/test_result.proto (right): https://codereview.chromium.org/2797023002/diff/20001/recipe_engine/test_result.proto#newcode63 recipe_engine/test_result.proto:63: InternalFailure internal_failure = 3; I suspect ...
3 years, 8 months ago (2017-04-04 20:24:51 UTC) #4
Paweł Hajdan Jr.
PTAL. Suggestions are welcome. https://codereview.chromium.org/2797023002/diff/20001/recipe_engine/test_result.proto File recipe_engine/test_result.proto (right): https://codereview.chromium.org/2797023002/diff/20001/recipe_engine/test_result.proto#newcode63 recipe_engine/test_result.proto:63: InternalFailure internal_failure = 3; On ...
3 years, 8 months ago (2017-04-04 20:32:04 UTC) #11
iannucci
yep lgtm. I saw the tests later and forgot to remove the question from the ...
3 years, 8 months ago (2017-04-04 20:34:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797023002/60001
3 years, 8 months ago (2017-04-04 20:35:03 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 20:38:20 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/recipes-py/commit/0586f16a4911be4855ce52621e143662e1d...

Powered by Google App Engine
This is Rietveld 408576698