Always identify test names that lead to failures

recipe_engine/test.py

 # Copyright 2017 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from __future__ import print_function
 
 import argparse
 import bdb
 import cStringIO
 import contextlib
@@ skipping 525 matching lines @@
 
 
 def worker(f):
   """Wrapper for a multiprocessing worker function.
 
   This addresses known issues with multiprocessing workers:
 
     - they can hang on uncaught exceptions
     - we need explicit kill switch to clearly terminate parent"""
   @functools.wraps(f)
-  def wrapper(*args, **kwargs):
+  def wrapper(test, *args, **kwargs):
     try:
       if _KILL_SWITCH.is_set():
-        return (False, 'kill switch')
-      return (True, f(*args, **kwargs))
+        return (False, test, 'kill switch')
+      return (True, test, f(test, *args, **kwargs))
     except Exception:
-      return (False, traceback.format_exc())
+      return (False, test, traceback.format_exc())
   return wrapper
 
 
 @worker
 def run_worker(test, debug=False, train=False):
   """Worker for 'run' command (note decorator above)."""
   return run_test(test, debug=debug, train=train)
 
 
 def scan_for_expectations(root, inside_expectations=False):
@@ skipping 47 matching lines @@
       results.append(run_worker(t, debug=debug, train=train))
   else:
     with kill_switch():
       pool = multiprocessing.Pool(jobs)
       results = pool.map(functools.partial(run_worker, train=train), tests)
 
   print()
 
   used_expectations = set()
 
-  for success, details in results:
+  for success, test_description, details in results:
     if success:
       assert isinstance(details, TestResult)
       if details.failures:
         rc = 1
         key = details.test_description.full_name
         print('%s failed:' % key)
         for failure in details.failures:
           results_proto.test_failures[key].failures.extend([failure.as_proto()])
           print(failure.format())
       coverage_data.update(details.coverage_data)
       if details.generates_expectation:
         used_expectations.add(details.test_description.expectation_path)
         used_expectations.add(
             os.path.dirname(details.test_description.expectation_path))
     else:
       rc = 1
       results_proto.valid = False
-      print('Internal failure:')
+      failure_proto = test_result_pb2.TestResult.TestFailure()
+      failure_proto.internal_failure.MergeFrom(
+          test_result_pb2.TestResult.InternalFailure())
+      results_proto.test_failures[test_description.full_name].failures.extend([
+          failure_proto])
+      print('%s failed:' % test_description.full_name)
       print(details)
 
   if test_filter:
     print('NOTE: not checking coverage, because a filter is enabled')
   else:
     try:
       # TODO(phajdan.jr): Add API to coverage to load data from memory.
       with tempfile.NamedTemporaryFile(delete=False) as coverage_file:
         coverage_data.write_file(coverage_file.name)
 
@@ skipping 229 matching lines @@
   Returns:
     Exit code
   """
   global _UNIVERSE_VIEW
   _UNIVERSE_VIEW = universe_view
   global _ENGINE_FLAGS
   _ENGINE_FLAGS = engine_flags
 
   args = parse_args(raw_args)
   return args.func(args)