Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: recipe_engine/test_result.proto

Issue 2797023002: Always identify test names that lead to failures (Closed)
Patch Set: proto Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « recipe_engine/test.py ('k') | recipe_engine/test_result_pb2.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/test_result.proto
diff --git a/recipe_engine/test_result.proto b/recipe_engine/test_result.proto
index 25ac5f72261630904b298cfca5029cb4fd6cdd89..281c28d100346316fefba90e29a6159710b3e770 100644
--- a/recipe_engine/test_result.proto
+++ b/recipe_engine/test_result.proto
@@ -51,11 +51,19 @@ message TestResult {
int64 lineno = 6;
}
+ // An internal failure (either ctrl-c interruption, or an exception
+ // while running the test; this could mean a crashing recipe execution,
+ // or even failure in the test runner itself).
+ message InternalFailure {
+ }
+
message TestFailure {
oneof failures {
DiffFailure diff_failure = 1;
CheckFailure check_failure = 2;
+
+ InternalFailure internal_failure = 3;
}
}
« no previous file with comments | « recipe_engine/test.py ('k') | recipe_engine/test_result_pb2.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698