Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: content/browser/background_fetch/background_fetch_data_manager_unittest.cc

Issue 2796933003: Store BackgroundFetchRequestInfo in a refcounted pointer (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_data_manager_unittest.cc
diff --git a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
index dfb89344cc59113fef1c8e8fa95cdcb667914518..9e4eb46229ba2ebb05eba02ae8f498fe852a8cc7 100644
--- a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
+++ b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
@@ -36,7 +36,8 @@ class BackgroundFetchDataManagerTest : public BackgroundFetchTestBase {
const std::vector<ServiceWorkerFetchRequest>& requests,
const BackgroundFetchOptions& options,
blink::mojom::BackgroundFetchError* out_error,
- std::vector<BackgroundFetchRequestInfo>* out_initial_requests) {
+ std::vector<scoped_refptr<BackgroundFetchRequestInfo>>*
+ out_initial_requests) {
DCHECK(out_error);
base::RunLoop run_loop;
@@ -66,9 +67,10 @@ class BackgroundFetchDataManagerTest : public BackgroundFetchTestBase {
void DidCreateRegistration(
base::Closure quit_closure,
blink::mojom::BackgroundFetchError* out_error,
- std::vector<BackgroundFetchRequestInfo>* out_initial_requests,
+ std::vector<scoped_refptr<BackgroundFetchRequestInfo>>*
+ out_initial_requests,
blink::mojom::BackgroundFetchError error,
- std::vector<BackgroundFetchRequestInfo> initial_requests) {
+ std::vector<scoped_refptr<BackgroundFetchRequestInfo>> initial_requests) {
*out_error = error;
*out_initial_requests = std::move(initial_requests);
@@ -98,7 +100,7 @@ TEST_F(BackgroundFetchDataManagerTest, NoDuplicateRegistrations) {
BackgroundFetchOptions options;
blink::mojom::BackgroundFetchError error;
- std::vector<BackgroundFetchRequestInfo> initial_requests;
+ std::vector<scoped_refptr<BackgroundFetchRequestInfo>> initial_requests;
// Deleting the not-yet-created registration should fail.
ASSERT_NO_FATAL_FAILURE(DeleteRegistration(registration_id, &error));

Powered by Google App Engine
This is Rietveld 408576698