Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 2796753002: Reland of Enable Mac headless tests now that headless targets are included on Mac build. (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #1 id:1 of https://codereview.chromium.org/2792893002/ ) Reason for revert: Rollforward: Enable Mac headless tests now that headless targets are included on Mac build The issue has been fixed in: https://codereview.chromium.org/2792913002/ Original issue's description: > Revert of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #2 id:20001 of https://codereview.chromium.org/2783053002/ ) > > Reason for revert: > These tests are failing on Mac10.10 Tests > > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests > > Original issue's description: > > Enable Mac headless tests now that headless targets are included on Mac build. > > > > BUG=687407 > > > > Review-Url: https://codereview.chromium.org/2783053002 > > Cr-Commit-Position: refs/heads/master@{#461362} > > Committed: https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a > > TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=687407 > > Review-Url: https://codereview.chromium.org/2792893002 > Cr-Commit-Position: refs/heads/master@{#461370} > Committed: https://chromium.googlesource.com/chromium/src/+/1442dca9acb9b78f2c2b047ec77f01e60f266796 TBR=dpranke@chromium.org,skyostil@chromium.org,timloh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687407 Review-Url: https://codereview.chromium.org/2796753002 Cr-Commit-Position: refs/heads/master@{#461581} Committed: https://chromium.googlesource.com/chromium/src/+/3447e1d1191f2462d31ea619becd4d32a625cee0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dvallet
Created Reland of Enable Mac headless tests now that headless targets are included on Mac ...
3 years, 8 months ago (2017-04-03 22:24:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796753002/1
3 years, 8 months ago (2017-04-03 22:24:48 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-03 22:24:49 UTC) #5
Dirk Pranke
rs- lgtm.
3 years, 8 months ago (2017-04-03 22:44:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796753002/1
3 years, 8 months ago (2017-04-03 23:53:22 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 23:55:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3447e1d1191f2462d31ea619becd...

Powered by Google App Engine
This is Rietveld 408576698