Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2783053002: Enable Mac headless tests now that headless targets are included on Mac build. (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Mac headless tests now that headless targets are included on Mac build. BUG=687407 Review-Url: https://codereview.chromium.org/2783053002 Cr-Commit-Position: refs/heads/master@{#461362} Committed: https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a

Patch Set 1 #

Patch Set 2 : Update upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
dvallet
PTAL
3 years, 8 months ago (2017-03-30 02:00:33 UTC) #4
Sami
Thanks, lgtm!
3 years, 8 months ago (2017-03-30 10:32:27 UTC) #7
Dirk Pranke
lgtm (sorry for the delay).
3 years, 8 months ago (2017-03-31 23:02:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783053002/1
3 years, 8 months ago (2017-04-02 23:10:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/262991)
3 years, 8 months ago (2017-04-02 23:57:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783053002/20001
3 years, 8 months ago (2017-04-03 00:36:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a
3 years, 8 months ago (2017-04-03 02:34:46 UTC) #18
Timothy Loh
3 years, 8 months ago (2017-04-03 04:29:46 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2792893002/ by timloh@chromium.org.

The reason for reverting is: These tests are failing on Mac10.10 Tests

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests.

Powered by Google App Engine
This is Rietveld 408576698