Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2792893002: Revert of Enable Mac headless tests now that headless targets are included on Mac build. (Closed)

Created:
3 years, 8 months ago by Timothy Loh
Modified:
3 years, 8 months ago
Reviewers:
Dirk Pranke, dvallet, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable Mac headless tests now that headless targets are included on Mac build. (patchset #2 id:20001 of https://codereview.chromium.org/2783053002/ ) Reason for revert: These tests are failing on Mac10.10 Tests https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests Original issue's description: > Enable Mac headless tests now that headless targets are included on Mac build. > > BUG=687407 > > Review-Url: https://codereview.chromium.org/2783053002 > Cr-Commit-Position: refs/heads/master@{#461362} > Committed: https://chromium.googlesource.com/chromium/src/+/69dd94f8ffe4b3d279b599fe4bff3445e20c0c1a TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687407 Review-Url: https://codereview.chromium.org/2792893002 Cr-Commit-Position: refs/heads/master@{#461370} Committed: https://chromium.googlesource.com/chromium/src/+/1442dca9acb9b78f2c2b047ec77f01e60f266796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M testing/buildbot/chromium.mac.json View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
Created Revert of Enable Mac headless tests now that headless targets are included on Mac ...
3 years, 8 months ago (2017-04-03 04:29:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792893002/1
3 years, 8 months ago (2017-04-03 04:29:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1442dca9acb9b78f2c2b047ec77f01e60f266796
3 years, 8 months ago (2017-04-03 04:32:18 UTC) #6
Dirk Pranke
lgtm
3 years, 8 months ago (2017-04-03 16:53:55 UTC) #7
dvallet
3 years, 8 months ago (2017-04-03 22:24:03 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2796753002/ by dvallet@chromium.org.

The reason for reverting is: Rollforward: Enable Mac headless tests now that
headless targets are included on Mac build

The issue has been fixed in: https://codereview.chromium.org/2792913002/.

Powered by Google App Engine
This is Rietveld 408576698