Hide the download summary on file open

Hide the download summary on file open

Notifications can be dismissed with a
DownloadManager.ACTION_NOTIFICATION_CLICKED intent, which bypasses the
DownloadNotificationService so we don't get a chance to hide the
summary.  This adds a check to the
DownloadBroadcastReceiver#openDownload() path that allows us to hide any
dangling summary notifications that shouldn't be visible.  This also
lets us catch any clicks on the summary which gives us a chance to close
them out as well.

BUG=699323
Review-Url: https://codereview.chromium.org/2796573002
Cr-Commit-Position: refs/heads/master@{#461744}
Committed: https://chromium.googlesource.com/chromium/src/+/803fdf80f842803c7c91dca2a87419afe1b3d60c

[David Trainor- moved to gerrit, 2017-04-02 16:59:48]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-02 16:59:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2017-04-02 17:00:35]

dtrainor@chromium.org changed reviewers:
+ qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-04-02 17:00:36]

ptal thanks!

[commit-bot: I haz the power, 2017-04-02 17:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-02 17:39:20]

Dry run: This issue passed the CQ dry run.

[qinmin, 2017-04-03 18:50:47]

lgtm % comment

https://codereview.chromium.org/2796573002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2796573002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:173:
// other download notifications, but we can't close the summary.  Try to start
add UMA to see how often this happens?

[David Trainor- moved to gerrit, 2017-04-03 21:07:59]

dtrainor@chromium.org changed reviewers:
+ isherman@chromium.org

[David Trainor- moved to gerrit, 2017-04-03 21:08:00]

isherman@ ptal at histograms.xml.  Thanks!

[Ilya Sherman, 2017-04-04 00:07:53]

Metrics LGTM % a nit:

https://codereview.chromium.org/2796573002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2796573002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29711: +<histogram
name="MobileDownload.Notification.FixingSummaryLeak" enum="Boolean">
nit: (Just within this file), please use a custom enum, with labels like
"Foreground notification" vs. "Normal/background notification".

[David Trainor- moved to gerrit, 2017-04-04 15:24:16]

https://codereview.chromium.org/2796573002/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2796573002/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:29711: +<histogram
name="MobileDownload.Notification.FixingSummaryLeak" enum="Boolean">
On 2017/04/04 00:07:53, Ilya Sherman wrote:
> nit: (Just within this file), please use a custom enum, with labels like
> "Foreground notification" vs. "Normal/background notification".

Done.

[David Trainor- moved to gerrit, 2017-04-04 15:25:47]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-04 15:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2796573002/#ps100001
(title: "Updated enum to use a more detailed description of the values")

[commit-bot: I haz the power, 2017-04-04 15:26:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 16:32:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491319547453220,
"parent_rev": "5173eeca89c25e7ad01efd687879936ae474253f", "commit_rev":
"803fdf80f842803c7c91dca2a87419afe1b3d60c"}

[commit-bot: I haz the power, 2017-04-04 16:41:23]

Description was changed from

==========
Hide the download summary on file open

Notifications can be dismissed with a
DownloadManager.ACTION_NOTIFICATION_CLICKED intent, which bypasses the
DownloadNotificationService so we don't get a chance to hide the
summary.  This adds a check to the
DownloadBroadcastReceiver#openDownload() path that allows us to hide any
dangling summary notifications that shouldn't be visible.  This also
lets us catch any clicks on the summary which gives us a chance to close
them out as well.

BUG=699323
==========

to

==========
Hide the download summary on file open

Notifications can be dismissed with a
DownloadManager.ACTION_NOTIFICATION_CLICKED intent, which bypasses the
DownloadNotificationService so we don't get a chance to hide the
summary.  This adds a check to the
DownloadBroadcastReceiver#openDownload() path that allows us to hide any
dangling summary notifications that shouldn't be visible.  This also
lets us catch any clicks on the summary which gives us a chance to close
them out as well.

BUG=699323

Review-Url: https://codereview.chromium.org/2796573002
Cr-Commit-Position: refs/heads/master@{#461744}
Committed:
https://chromium.googlesource.com/chromium/src/+/803fdf80f842803c7c91dca2a874...
==========

[commit-bot: I haz the power, 2017-04-04 16:41:26]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/803fdf80f842803c7c91dca2a874...