Fix startForegroundService API calls.

Fix startForegroundService API calls.

Migrate to a new way of calling this, which does not involve sending the
notification to the start call.  Instead just make sure we move the
service to the foreground shortly after launching it.

BUG=707932
Review-Url: https://codereview.chromium.org/2797573002
Cr-Commit-Position: refs/heads/master@{#461844}
Committed: https://chromium.googlesource.com/chromium/src/+/81033db0364139db8ee059623d8892f2b00a39ba

[David Trainor- moved to gerrit, 2017-04-04 00:07:08]

dtrainor@chromium.org changed reviewers:
+ nyquist@chromium.org, zqzhang@chromium.org

[David Trainor- moved to gerrit, 2017-04-04 00:07:09]

nyquist@ ptal at all
zqzhang@ can you take a look at the MediaNotificationManager?  Should we be
calling Service.startForeground() explicitly now?  Feel free to ping me offline
and let me know if I need to do anything else.  Thanks!

thanks!

[nyquist, 2017-04-04 05:45:44]

lgtm

https://codereview.chromium.org/2797573002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2797573002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:461:
mShouldMakeForeground = false;
Optional nit: For my own sanity, could you put this immediately after the
if-statement? It makes it abundantly clear that we're always setting it.

Or is it important that it comes after startForegroundInternal()?

[Zhiqiang Zhang (Slow), 2017-04-04 10:28:52]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2017-04-04 10:28:53]

MediaNotificationManager lgtm

+mlamouri@ for rubber-stamping

[mlamouri (slow - plz ping), 2017-04-04 12:50:24]

lgtm

[David Trainor- moved to gerrit, 2017-04-04 15:31:02]

The CQ bit was checked by dtrainor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 15:31:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 17:09:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 17:09:24]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2017-04-04 21:08:36]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-04 21:08:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, zqzhang@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2797573002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-04 21:10:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 21:23:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491340116000350,
"parent_rev": "b1e592331aa12efbde84280e8b4e9248a7360c9d", "commit_rev":
"81033db0364139db8ee059623d8892f2b00a39ba"}

[commit-bot: I haz the power, 2017-04-04 21:24:23]

Description was changed from

==========
Fix startForegroundService API calls.

Migrate to a new way of calling this, which does not involve sending the
notification to the start call.  Instead just make sure we move the
service to the foreground shortly after launching it.

BUG=707932
==========

to

==========
Fix startForegroundService API calls.

Migrate to a new way of calling this, which does not involve sending the
notification to the start call.  Instead just make sure we move the
service to the foreground shortly after launching it.

BUG=707932

Review-Url: https://codereview.chromium.org/2797573002
Cr-Commit-Position: refs/heads/master@{#461844}
Committed:
https://chromium.googlesource.com/chromium/src/+/81033db0364139db8ee059623d88...
==========

[commit-bot: I haz the power, 2017-04-04 21:24:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/81033db0364139db8ee059623d88...