tools/metrics/histograms/histograms.xml - Issue 2796573002: Hide the download summary on file open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2796573002: Hide the download summary on file open (Closed)

Patch Set: Cleaned up the logic a bit and fixed the UMA stat Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 04429b49734f785597aa9566c716d50b041ad851..fa864169aeca03c3bfb66a0678d035546cba638e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -29708,6 +29708,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="MobileDownload.Notification.FixingSummaryLeak" enum="Boolean">

Ilya Sherman 2017/04/04 00:07:53 nit: (Just within this file), please use a custom

David Trainor- moved to gerrit 2017/04/04 15:24:16 Done.

+ <owner>dtrainor@chromium.org</owner>

+ <summary>

+ Android: Records the situation where we try to fix a standalone downloads

+ summary notification, which shouldn't be visible to the user. True if the

+ notification was a foreground notification, in which case we can't dismiss

+ it and need to attempt a more drastic workaround. False if it was a normal

+ notification and we can dismiss it easily (this is okay and expected

+ behavior in some scenarios).

+ </summary>

+</histogram>

<owner>gogerald@chromium.org</owner>

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | no next file » | no next file with comments »