Issue 279563002: hide get/setLocalMatrix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 279563002: hide get/setLocalMatrix (Closed)

Created:
6 years, 7 months ago by reed1

Modified:
6 years, 7 months ago

Reviewers:
Dominik Grewe, f(malita), fmalita_google_do_not_use

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -30 lines)			Patch
M	include/core/SkShader.h	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	samplecode/SampleFatBits.cpp	View	1 2	3 chunks	+4 lines, -6 lines	0 comments	Download
M	src/core/SkPictureShader.cpp	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	src/core/SkShader.cpp	View		3 chunks	+6 lines, -9 lines	0 comments	Download
M	src/effects/SkRectShaderImageFilter.cpp	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFDeviceFlattener.cpp	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 7 (0 generated)

Dominik Grewe

On 2014/05/09 14:57:01, Florin Malita wrote: > lgtm lgtm

6 years, 7 months ago (2014-05-09 14:58:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/279563002/30001

6 years, 7 months ago (2014-05-09 15:13:13 UTC) #5

reed1

6 years, 7 months ago (2014-05-09 15:41:03 UTC) #7

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/278903002/ by reed@google.com.

The reason for reverting is: broke gms.