Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: tools/binary_size/integration_test.py

Issue 2795593005: //tools/binary_size: Various enhancements to console.py (Closed)
Patch Set: Review fixes Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/binary_size/describe.py ('k') | tools/binary_size/map2size.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/integration_test.py
diff --git a/tools/binary_size/integration_test.py b/tools/binary_size/integration_test.py
index 670cb97c7fe9bd0c51bd5f1ad7ae8367d431c3e9..0523d913be9da943e90a926d81ce61736f47b06c 100755
--- a/tools/binary_size/integration_test.py
+++ b/tools/binary_size/integration_test.py
@@ -84,11 +84,11 @@ class IntegrationTest(unittest.TestCase):
def test_ActualDiff(self):
map1 = self._GetParsedMap()
map2 = self._GetParsedMap()
- map1.symbols.symbols.pop(-1)
- map2.symbols.symbols.pop(0)
+ map1.symbols -= map1.symbols[0]
+ map2.symbols -= map2.symbols[-1]
map1.symbols[1].size -= 10
diff = models.Diff(map1, map2)
- return describe.GenerateLines(diff)
+ return describe.GenerateLines(diff, verbose=True)
@_CompareWithGolden
def test_SymbolGroupMethods(self):
@@ -96,10 +96,10 @@ class IntegrationTest(unittest.TestCase):
global_syms = all_syms.WhereNameMatches('GLOBAL')
# Tests Filter(), Inverted(), and __sub__().
non_global_syms = global_syms.Inverted()
- self.assertEqual(non_global_syms.symbols, (all_syms - global_syms).symbols)
+ self.assertEqual(non_global_syms, (all_syms - global_syms))
# Tests Sorted() and __add__().
- self.assertEqual(all_syms.Sorted().symbols,
- (global_syms + non_global_syms).Sorted().symbols)
+ self.assertEqual(all_syms.Sorted(),
+ (global_syms + non_global_syms).Sorted())
# Tests GroupByNamespace() and __len__().
return itertools.chain(
['GroupByNamespace()'],
« no previous file with comments | « tools/binary_size/describe.py ('k') | tools/binary_size/map2size.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698