Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2794013002: Fewer reused duplicate symbol names in animation. (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fewer reused duplicate symbol names in animation. When experimenting with unity builds you get conflicts between cpp files if they use the same symbol name for different things (or the same thing). This make names more unique. No functional changes. Formatted with git cl format (#includes moving around). R=alancutter@chromium.org Review-Url: https://codereview.chromium.org/2794013002 Cr-Commit-Position: refs/heads/master@{#461755} Committed: https://chromium.googlesource.com/chromium/src/+/f88e1c7fcb7e4ea137e9c62a1ebbe76182bdc5f3

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -101 lines) Patch
M third_party/WebKit/Source/core/animation/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp View 1 chunk +2 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/core/animation/FontWeightConversion.h View 1 chunk +17 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/FontWeightConversion.cpp View 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 1 4 chunks +6 lines, -5 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SideIndex.h View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +1 line, -26 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Daniel Bratell
3 years, 8 months ago (2017-04-03 15:46:33 UTC) #1
alancutter (OOO until 2018)
lgtm after name changes. https://codereview.chromium.org/2794013002/diff/1/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp File third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp (right): https://codereview.chromium.org/2794013002/diff/1/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp#newcode13 third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp:13: const FillLayer* getFillLayerForPos(CSSPropertyID property, s/Pos/Position/ ...
3 years, 8 months ago (2017-04-04 00:15:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794013002/20001
3 years, 8 months ago (2017-04-04 15:06:40 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 17:08:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f88e1c7fcb7e4ea137e9c62a1ebb...

Powered by Google App Engine
This is Rietveld 408576698