third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp - Issue 2794013002: Fewer reused duplicate symbol names in animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

Issue 2794013002: Fewer reused duplicate symbol names in animation. (Closed)

Patch Set: Addressed review comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/FontWeightConversion.cpp ('k') | third_party/WebKit/Source/core/animation/SideIndex.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

diff --git a/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

index 6f65bbf4d6ce4070f5724dd33c4de558128707b2..0751cc84e0907e1db3a9ea10a6f5536d6ede26eb 100644

--- a/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

+++ b/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

@@ -10,8 +10,8 @@ namespace blink {

namespace {

-const FillLayer* getFillLayer(CSSPropertyID property,

- const ComputedStyle& style) {

+const FillLayer* getFillLayerForPosition(CSSPropertyID property,

+ const ComputedStyle& style) {

switch (property) {

case CSSPropertyBackgroundPositionX:

case CSSPropertyBackgroundPositionY:

@@ -25,7 +25,8 @@ const FillLayer* getFillLayer(CSSPropertyID property,

}

-FillLayer* accessFillLayer(CSSPropertyID property, ComputedStyle& style) {

+FillLayer* accessFillLayerForPosition(CSSPropertyID property,

+ ComputedStyle& style) {

switch (property) {

case CSSPropertyBackgroundPositionX:

case CSSPropertyBackgroundPositionY:

@@ -159,7 +160,7 @@ bool LengthListPropertyFunctions::getLengthList(CSSPropertyID property,

case CSSPropertyBackgroundPositionY:

case CSSPropertyWebkitMaskPositionX:

case CSSPropertyWebkitMaskPositionY: {

- const FillLayer* fillLayer = getFillLayer(property, style);

+ const FillLayer* fillLayer = getFillLayerForPosition(property, style);

FillLayerMethods fillLayerMethods(property);

while (fillLayer && (fillLayer->*fillLayerMethods.isSet)()) {

result.push_back((fillLayer->*fillLayerMethods.getLength)());

@@ -241,7 +242,7 @@ void LengthListPropertyFunctions::setLengthList(CSSPropertyID property,

case CSSPropertyBackgroundPositionY:

case CSSPropertyWebkitMaskPositionX:

case CSSPropertyWebkitMaskPositionY: {

- FillLayer* fillLayer = accessFillLayer(property, style);

+ FillLayer* fillLayer = accessFillLayerForPosition(property, style);

FillLayer* prev = nullptr;

FillLayerMethods fillLayerMethods(property);

for (size_t i = 0; i < lengthList.size(); i++) {