Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp

Issue 2794013002: Fewer reused duplicate symbol names in animation. (Closed)
Patch Set: Addressed review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp
diff --git a/third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp b/third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp
index 950ea6a22f9710a51419d7c9f1da0856db1864db..1bf9ec324c1c88a0ce95dadc9f30fafbcc7781f4 100644
--- a/third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp
+++ b/third_party/WebKit/Source/core/animation/SizeListPropertyFunctions.cpp
@@ -8,8 +8,8 @@
namespace blink {
-static const FillLayer* getFillLayer(CSSPropertyID property,
- const ComputedStyle& style) {
+static const FillLayer* getFillLayerForSize(CSSPropertyID property,
+ const ComputedStyle& style) {
switch (property) {
case CSSPropertyBackgroundSize:
return &style.backgroundLayers();
@@ -21,8 +21,8 @@ static const FillLayer* getFillLayer(CSSPropertyID property,
}
}
-static FillLayer* accessFillLayer(CSSPropertyID property,
- ComputedStyle& style) {
+static FillLayer* accessFillLayerForSize(CSSPropertyID property,
+ ComputedStyle& style) {
switch (property) {
case CSSPropertyBackgroundSize:
return &style.accessBackgroundLayers();
@@ -41,7 +41,7 @@ SizeList SizeListPropertyFunctions::getInitialSizeList(CSSPropertyID property) {
SizeList SizeListPropertyFunctions::getSizeList(CSSPropertyID property,
const ComputedStyle& style) {
SizeList result;
- for (const FillLayer* fillLayer = getFillLayer(property, style);
+ for (const FillLayer* fillLayer = getFillLayerForSize(property, style);
fillLayer && fillLayer->isSizeSet(); fillLayer = fillLayer->next())
result.push_back(fillLayer->size());
return result;
@@ -50,7 +50,7 @@ SizeList SizeListPropertyFunctions::getSizeList(CSSPropertyID property,
void SizeListPropertyFunctions::setSizeList(CSSPropertyID property,
ComputedStyle& style,
const SizeList& sizeList) {
- FillLayer* fillLayer = accessFillLayer(property, style);
+ FillLayer* fillLayer = accessFillLayerForSize(property, style);
FillLayer* prev = nullptr;
for (const FillSize& size : sizeList) {
if (!fillLayer)

Powered by Google App Engine
This is Rietveld 408576698