Make GeometryMapper fully static

Make GeometryMapper fully static.

Now that the cache for GeometryMapper is not stored on that object,
we don't really need to allocate GeometryMapper objects at all. This
change lets us avoid the cost and plumbing complexity of such objects.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2793993003
Cr-Commit-Position: refs/heads/master@{#461510}
Committed: https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2076bf3c1f55f

[chrishtr, 2017-04-03 17:39:52]

Description was changed from

==========
none


none

BUG=
==========

to

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-03 17:41:53]

Description was changed from

==========
none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make GeometryMapper fully static.

Now that the cache for GeometryMapper is not stored on that object,
we don't really need to allocate GeometryMapper objects at all. This
change lets us avoid the cost and plumbing complexity of such objects.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-04-03 17:42:21]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org, wangxianzhu@chromium.org

[Xianzhu, 2017-04-03 17:47:48]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-04-03 17:47:48]

lgtm

[commit-bot: I haz the power, 2017-04-03 17:48:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:49:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491241668049700, "parent_rev":
"57a47c3f25ab6992306269e41e47374a59786f0a", "commit_rev":
"36076bf3d6dbb233b8d3aa854353f00a9dcd0804"}

[commit-bot: I haz the power, 2017-04-03 19:55:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491241668049700, "parent_rev":
"464ad32bee3a812ad6d45bbb5dcf476ac0bbe2d8", "commit_rev":
"0be71969c80ff018be92afb6bba2076bf3c1f55f"}

[commit-bot: I haz the power, 2017-04-03 19:56:18]

Description was changed from

==========
Make GeometryMapper fully static.

Now that the cache for GeometryMapper is not stored on that object,
we don't really need to allocate GeometryMapper objects at all. This
change lets us avoid the cost and plumbing complexity of such objects.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Make GeometryMapper fully static.

Now that the cache for GeometryMapper is not stored on that object,
we don't really need to allocate GeometryMapper objects at all. This
change lets us avoid the cost and plumbing complexity of such objects.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2793993003
Cr-Commit-Position: refs/heads/master@{#461510}
Committed:
https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2...
==========

[commit-bot: I haz the power, 2017-04-03 19:56:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0be71969c80ff018be92afb6bba2...

[haraken, 2017-04-03 23:55:26]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-04-03 23:55:27]

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right):

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:31:
USING_FAST_MALLOC(GeometryMapper);

You can remove this and instead use STATIC_ONLY :)

[chrishtr, 2017-04-03 23:57:17]

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h (right):

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h:31:
USING_FAST_MALLOC(GeometryMapper);
On 2017/04/03 at 23:55:27, haraken wrote:
> You can remove this and instead use STATIC_ONLY :)

Good catch - patch coming.

[haraken, 2017-04-04 00:00:32]

haraken@chromium.org changed reviewers:
+ keishi@chromium.org

[haraken, 2017-04-04 00:00:33]

+keishi@: Would it be possible to improve the GC plugin to detect a
static-member-only class and ask developers to use STATIC_ONLY? (This is not a
high priority though.)

[Timothy Loh, 2017-04-04 03:25:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2798513002/ by timloh@chromium.org.

The reason for reverting is: Broke blink_platform_unittests on WebKit Linux
Trusty (dbg)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

failed 20
Run on OS: 'Ubuntu-14.04'
failures:
GeometryMapperTest.FilterWithClipsAndTransforms
GeometryMapperTest.RoundedClip
GeometryMapperTest.TwoClipsWithTransformBetween
GeometryMapperTest.Root
GeometryMapperTest.ClipAfterTransform
GeometryMapperTest.TwoClipsTransformAbove
GeometryMapperTest.ReflectionWithPaintOffset
GeometryMapperTest.SimpleClip
GeometryMapperTest.SiblingTransforms
GeometryMapperTest.RotationAndScaleTransform
GeometryMapperTest.NestedTransformsScaleAndTranslation
GeometryMapperTest.TranslationTransform
GeometryMapperTest.NestedTransformsIntermediateDestination
GeometryMapperTest.SiblingTransformsWithClip
GeometryMapperTest.NestedTransformsFlattening
GeometryMapperTest.RotationAndScaleTransformWithTransformOrigin
GeometryMapperTest.TwoClips
GeometryMapperTest.IdentityTransform
GeometryMapperTest.NestedTransforms
GeometryMapperTest.ClipBeforeTransform

Sample stack trace:

[ RUN      ] GeometryMapperTest.ClipAfterTransform
../../build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.8/../../../../include/c++/4.8/bits/unique_ptr.h:228:
std::unique_ptr::pointer std::unique_ptr<blink::GeometryMapper,
std::default_delete<blink::GeometryMapper> >::operator->() const [_Tp =
blink::GeometryMapper, _Dp = std::default_delete<blink::GeometryMapper>]:
Assertion 'get() != pointer()' failed.
Received signal 6
#0 0x7fe3a88626bb base::debug::StackTrace::StackTrace()
#1 0x7fe3a88613bc base::debug::StackTrace::StackTrace()
#2 0x7fe3a88621cf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#3 0x7fe3a9d72330 <unknown>
#4 0x7fe3a42cbc37 gsignal
#5 0x7fe3a42cf028 abort
#6 0x000000566ccf std::__replacement_assert()
#7 0x0000007706d6 std::unique_ptr<>::operator->()
#8 0x00000075a4b0 blink::GeometryMapperTest_ClipAfterTransform_Test::TestBody()
#9 0x000000eee60e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#10 0x000000ede742 testing::internal::HandleExceptionsInMethodIfSupported<>()
#11 0x000000ed3216 testing::Test::Run()
#12 0x000000ed39cd testing::TestInfo::Run()
#13 0x000000ed3f6f testing::TestCase::Run()
#14 0x000000ed92dc testing::internal::UnitTestImpl::RunAllTests()
#15 0x000000ef259e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#16 0x000000edffd2 testing::internal::HandleExceptionsInMethodIfSupported<>()
#17 0x000000ed8f7f testing::UnitTest::Run()
#18 0x000000e2c431 RUN_ALL_TESTS()
#19 0x000000e2b2d2 base::TestSuite::Run()
#20 0x000000a36565 (anonymous namespace)::runTestSuite()
#21 0x0000005e3a6a
_ZN4base8internal13FunctorTraitsIPFvPiEvE6InvokeIJS2_EEEvS4_DpOT_
#22 0x000000a36858
_ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKPFiPNS_9TestSuiteEEJS5_EEEiOT_DpOT0_
#23 0x000000a36817
_ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#24 0x000000a3675c
_ZN4base8internal7InvokerINS0_9BindStateIPFiPNS_9TestSuiteEEJNS0_17UnretainedWrapperIS3_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#25 0x00000082056d
_ZNKR4base8CallbackIFvvELNS_8internal8CopyModeE1ELNS2_10RepeatModeE1EE3RunEv
#26 0x000000e50a16 base::(anonymous namespace)::LaunchUnitTestsInternal()
#27 0x000000e50884 base::LaunchUnitTests()
#28 0x000000a364c1 main
#29 0x7fe3a42b6f45 __libc_start_main
#30 0x00000052eb84 <unknown>
  r8: 29287265746e696f  r9: 696c623c6574656c r10: 0000000000000008 r11:
0000000000000206
 r12: 000000000052eb5b r13: 00007ffd79a846a0 r14: 0000000000000000 r15:
0000000000000000
  di: 0000000000006c05  si: 0000000000006c05  bp: 00007ffd79a82540  bx:
0000000000000000
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp:
00007ffd79a823d8
  ip: 00007fe3a42cbc37 efl: 0000000000000206 cgf: 0000000000000033 erf:
0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated..

[tasak, 2017-04-04 07:40:25]

tasak@google.com changed reviewers:
+ tasak@google.com

[tasak, 2017-04-04 07:40:26]

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp
(left):

https://codereview.chromium.org/2793993003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/GeometryMapperTest.cpp:78:
void TearDown() override { geometryMapper.reset(); }
I think, we still need this? Because this test uses geometryMapper (c.f.
CHECK_MAPPINGS).