[ImageFetcher] Return http response headers

[ImageFetcher] Return http response headers

For LargeIconService, we need to access Content-Location header for
images fetched by ImageFetcher. This CL reveals HttpResponseHeaders* in
image_fetcher::RequestMetadata.

BUG=644102
Review-Url: https://codereview.chromium.org/2793983002
Cr-Commit-Position: refs/heads/master@{#462891}
Committed: https://chromium.googlesource.com/chromium/src/+/a7c962cd009df5796428aa072e9a41603526ca71

[jkrcal, 2017-04-03 15:00:28]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:00:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-04-03 15:00:58]

jkrcal@chromium.org changed reviewers:
+ markusheintz@chromium.org

[jkrcal, 2017-04-03 15:00:59]

Markus, could you PTAL?

[commit-bot: I haz the power, 2017-04-03 15:21:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:21:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jkrcal, 2017-04-04 09:47:34]

On 2017/04/03 15:00:59, jkrcal wrote:
> Markus, could you PTAL?

FYI, I just updated the CL to fix unit-test errors.

[markusheintz_, 2017-04-04 13:33:36]

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
File components/image_fetcher/core/request_metadata.cc (right):

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
components/image_fetcher/core/request_metadata.cc:15: // Do not compare
|http_response_headers| as this is solely used in
I don't understand this comment. Do we really only add the headers for the
tests?

[jkrcal, 2017-04-04 16:42:02]

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
File components/image_fetcher/core/request_metadata.cc (right):

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
components/image_fetcher/core/request_metadata.cc:15: // Do not compare
|http_response_headers| as this is solely used in
On 2017/04/04 13:33:36, markusheintz_ wrote:
> I don't understand this comment. Do we really only add the headers for the
> tests?

I rephrased the comment.

[jkrcal, 2017-04-05 17:13:38]

On 2017/04/04 16:42:02, jkrcal wrote:
>
https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
> File components/image_fetcher/core/request_metadata.cc (right):
> 
>
https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
> components/image_fetcher/core/request_metadata.cc:15: // Do not compare
> |http_response_headers| as this is solely used in
> On 2017/04/04 13:33:36, markusheintz_ wrote:
> > I don't understand this comment. Do we really only add the headers for the
> > tests?
> 
> I rephrased the comment.

Markus, friendly ping! Could you PTAL?

[markusheintz_, 2017-04-06 08:52:03]

Sorry for the delay

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
File components/image_fetcher/core/request_metadata.cc (right):

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
components/image_fetcher/core/request_metadata.cc:15: // Do not compare
|http_response_headers| as this is solely used in
On 2017/04/04 16:42:02, jkrcal wrote:
> On 2017/04/04 13:33:36, markusheintz_ wrote:
> > I don't understand this comment. Do we really only add the headers for the
> > tests?
> 
> I rephrased the comment.

Oh so the equals operator is only used in test! I guess that's hard to ensure
for the future since this is not obvious to user. Let's quickly sync on this in
person

[jkrcal, 2017-04-06 14:17:19]

The CQ bit was checked by jkrcal@chromium.org to run a CQ dry run

[jkrcal, 2017-04-06 14:17:33]

Marcus, could you PTAL again?

[commit-bot: I haz the power, 2017-04-06 14:17:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkrcal, 2017-04-06 14:18:23]

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
File components/image_fetcher/core/request_metadata.cc (right):

https://codereview.chromium.org/2793983002/diff/20001/components/image_fetche...
components/image_fetcher/core/request_metadata.cc:15: // Do not compare
|http_response_headers| as this is solely used in
On 2017/04/06 08:52:03, markusheintz_ wrote:
> On 2017/04/04 16:42:02, jkrcal wrote:
> > On 2017/04/04 13:33:36, markusheintz_ wrote:
> > > I don't understand this comment. Do we really only add the headers for the
> > > tests?
> > 
> > I rephrased the comment.
> 
> Oh so the equals operator is only used in test! I guess that's hard to ensure
> for the future since this is not obvious to user. Let's quickly sync on this
in
> person

Okay, I added the check also for the headers.

[commit-bot: I haz the power, 2017-04-06 15:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:20:45]

Dry run: This issue passed the CQ dry run.

[jkrcal, 2017-04-07 12:26:34]

Friendly ping!

[markusheintz_, 2017-04-07 15:41:46]

On 2017/04/07 12:26:34, jkrcal wrote:
> Friendly ping!

LGTM

[jkrcal, 2017-04-07 15:42:28]

The CQ bit was checked by jkrcal@chromium.org

[commit-bot: I haz the power, 2017-04-07 15:42:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:39:03]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491579748817670,
"parent_rev": "125a3532433159edc1041c7f031d733df0c7682d", "commit_rev":
"a7c962cd009df5796428aa072e9a41603526ca71"}

[commit-bot: I haz the power, 2017-04-07 16:39:54]

Description was changed from

==========
[ImageFetcher] Return http response headers

For LargeIconService, we need to access Content-Location header for
images fetched by ImageFetcher. This CL reveals HttpResponseHeaders* in
image_fetcher::RequestMetadata.

BUG=644102
==========

to

==========
[ImageFetcher] Return http response headers

For LargeIconService, we need to access Content-Location header for
images fetched by ImageFetcher. This CL reveals HttpResponseHeaders* in
image_fetcher::RequestMetadata.

BUG=644102

Review-Url: https://codereview.chromium.org/2793983002
Cr-Commit-Position: refs/heads/master@{#462891}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7c962cd009df5796428aa072e9a...
==========

[commit-bot: I haz the power, 2017-04-07 16:39:55]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a7c962cd009df5796428aa072e9a...