Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: components/image_fetcher/core/request_metadata.h

Issue 2793983002: [ImageFetcher] Return http response headers (Closed)
Patch Set: Compare headers as well Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/image_fetcher/core/request_metadata.h
diff --git a/components/image_fetcher/core/request_metadata.h b/components/image_fetcher/core/request_metadata.h
index fbff28c177704a6c875386b1c7a739dcde13d0a0..f625c8294d84d306a0bb39a23cc6cf0574e974df 100644
--- a/components/image_fetcher/core/request_metadata.h
+++ b/components/image_fetcher/core/request_metadata.h
@@ -24,6 +24,12 @@ struct RequestMetadata {
std::string mime_type;
int http_response_code;
bool from_http_cache;
+
+ // Is guaranteed to be a valid pointer only when the callback is called. The
+ // headers may get deleted right after the callback finishes.
+ // TODO(jkrcal): Remove |mime_type| and |http_response_code| as it all can be
+ // read from HttpResponseHeaders.
+ net::HttpResponseHeaders* http_response_headers;
};
bool operator==(const RequestMetadata& lhs, const RequestMetadata& rhs);
« no previous file with comments | « components/image_fetcher/core/image_data_fetcher_unittest.cc ('k') | components/image_fetcher/core/request_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698