Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: components/image_fetcher/core/request_metadata.h

Issue 2793983002: [ImageFetcher] Return http response headers (Closed)
Patch Set: Compare headers as well Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_ 5 #ifndef COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_
6 #define COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_ 6 #define COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "net/url_request/url_fetcher.h" 10 #include "net/url_request/url_fetcher.h"
11 11
12 namespace image_fetcher { 12 namespace image_fetcher {
13 13
14 // Metadata for a URL request. 14 // Metadata for a URL request.
15 struct RequestMetadata { 15 struct RequestMetadata {
16 // Impossible http response code. Used to signal that no http response code 16 // Impossible http response code. Used to signal that no http response code
17 // was received. 17 // was received.
18 enum ResponseCode { 18 enum ResponseCode {
19 RESPONSE_CODE_INVALID = net::URLFetcher::RESPONSE_CODE_INVALID 19 RESPONSE_CODE_INVALID = net::URLFetcher::RESPONSE_CODE_INVALID
20 }; 20 };
21 21
22 RequestMetadata(); 22 RequestMetadata();
23 23
24 std::string mime_type; 24 std::string mime_type;
25 int http_response_code; 25 int http_response_code;
26 bool from_http_cache; 26 bool from_http_cache;
27
28 // Is guaranteed to be a valid pointer only when the callback is called. The
29 // headers may get deleted right after the callback finishes.
30 // TODO(jkrcal): Remove |mime_type| and |http_response_code| as it all can be
31 // read from HttpResponseHeaders.
32 net::HttpResponseHeaders* http_response_headers;
27 }; 33 };
28 34
29 bool operator==(const RequestMetadata& lhs, const RequestMetadata& rhs); 35 bool operator==(const RequestMetadata& lhs, const RequestMetadata& rhs);
30 bool operator!=(const RequestMetadata& lhs, const RequestMetadata& rhs); 36 bool operator!=(const RequestMetadata& lhs, const RequestMetadata& rhs);
31 37
32 } // namespace image_fetcher 38 } // namespace image_fetcher
33 39
34 #endif // COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_ 40 #endif // COMPONENTS_IMAGE_FETCHER_CORE_REQUEST_METADATA_H_
OLDNEW
« no previous file with comments | « components/image_fetcher/core/image_data_fetcher_unittest.cc ('k') | components/image_fetcher/core/request_metadata.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698