[Interpreter] Optimize code of the form 'if (x === undefined)'.

[Interpreter] Optimize code of the form 'if (x === undefined)'.

Translates code of the form 'if (x === undefined)' into the JumpIfUndefined
bytecode, and similarly for comparisons with null. Also adds bytecodes for
JumpIfNotUndefined / Null.

Moves the peephole optimization for CompareUndefined out of the peephole
optimizer and into the BytecodeGenerator, having the side-effect of enabling
it for comparisons with undefined on both side of the compare operation.

BUG=v8:6107
Review-Url: https://codereview.chromium.org/2793923002
Cr-Commit-Position: refs/heads/master@{#44341}
Committed: https://chromium.googlesource.com/v8/v8/+/f4f58e31c1edf87ecbfc13f41718bc118f812d79

[rmcilroy, 2017-04-03 11:23:08]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 11:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 11:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 11:24:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38276)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[rmcilroy, 2017-04-03 11:25:10]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, mythria@chromium.org

[rmcilroy, 2017-04-03 11:25:10]

Mythri, PTAL at interpreter/
Benedikt, PTAL at compiler/

[Benedikt Meurer, 2017-04-03 11:27:15]

Awesome, thanks! LGTM on compiler.

[rmcilroy, 2017-04-03 11:54:33]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 11:54:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 12:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 12:18:25]

Dry run: This issue passed the CQ dry run.

[mythria, 2017-04-03 12:48:02]

Nice. lgtm.

[rmcilroy, 2017-04-03 14:15:32]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-04-03 14:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2793923002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-03 14:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 14:17:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491228932388580,
"parent_rev": "d73b11ecd205c405e0799d4487df3c151f4da56b", "commit_rev":
"f4f58e31c1edf87ecbfc13f41718bc118f812d79"}

[commit-bot: I haz the power, 2017-04-03 14:17:23]

Description was changed from

==========
[Interpreter] Optimize code of the form 'if (x === undefined)'.

Translates code of the form 'if (x === undefined)' into the JumpIfUndefined
bytecode, and similarly for comparisons with null. Also adds bytecodes for
JumpIfNotUndefined / Null.

Moves the peephole optimization for CompareUndefined out of the peephole
optimizer and into the BytecodeGenerator, having the side-effect of enabling
it for comparisons with undefined on both side of the compare operation.

BUG=v8:6107
==========

to

==========
[Interpreter] Optimize code of the form 'if (x === undefined)'.

Translates code of the form 'if (x === undefined)' into the JumpIfUndefined
bytecode, and similarly for comparisons with null. Also adds bytecodes for
JumpIfNotUndefined / Null.

Moves the peephole optimization for CompareUndefined out of the peephole
optimizer and into the BytecodeGenerator, having the side-effect of enabling
it for comparisons with undefined on both side of the compare operation.

BUG=v8:6107

Review-Url: https://codereview.chromium.org/2793923002
Cr-Commit-Position: refs/heads/master@{#44341}
Committed:
https://chromium.googlesource.com/v8/v8/+/f4f58e31c1edf87ecbfc13f41718bc118f8...
==========

[commit-bot: I haz the power, 2017-04-03 14:17:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f4f58e31c1edf87ecbfc13f41718bc118f8...