Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2795183002: [Interpreter] Move ToBoolean elision in BytecodeGenerator. (Closed)

Created:
3 years, 8 months ago by rmcilroy
Modified:
3 years, 8 months ago
Reviewers:
Leszek Swirski
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Move ToBoolean elision in BytecodeGenerator. Move the ToBoolean elision in the BytecodeGenerator instead of the peephole optimizer. Adds a TypeHint mechanism to the ExpressionResult to enable passing of type hints through the ast visitor. BUG=v8:6194

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -182 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 4 chunks +13 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 5 chunks +37 lines, -10 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 19 chunks +53 lines, -26 lines 0 comments Download
M src/interpreter/bytecode-peephole-optimizer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/interpreter/bytecode-peephole-table.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/interpreter/control-flow-builders.h View 4 chunks +15 lines, -8 lines 0 comments Download
M src/interpreter/control-flow-builders.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M src/interpreter/mkpeephole.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompareNil.golden View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/GenerateTestUndetectable.golden View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Switch.golden View 9 chunks +9 lines, -9 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 7 chunks +18 lines, -41 lines 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (6 generated)
rmcilroy
Leszek, PTAL thanks.
3 years, 8 months ago (2017-04-04 10:30:49 UTC) #6
rmcilroy
3 years, 8 months ago (2017-04-04 10:59:21 UTC) #7
Actually please review  https://chromium-review.googlesource.com/467208 instead
(uploaded via laptop but transferring to gerrit now).

Powered by Google App Engine
This is Rietveld 408576698