Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/interpreter/mkpeephole.cc

Issue 2793923002: [Interpreter] Optimize code of the form 'if (x === undefined)'. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/mkpeephole.cc
diff --git a/src/interpreter/mkpeephole.cc b/src/interpreter/mkpeephole.cc
index e6c3b76f2808b19c6a6b36fffd9188113d4ca437..62d3a77e02c7faf513f1d8ff020217b6fd4785dd 100644
--- a/src/interpreter/mkpeephole.cc
+++ b/src/interpreter/mkpeephole.cc
@@ -192,28 +192,6 @@ PeepholeActionAndData PeepholeActionTableWriter::LookupActionAndData(
}
}
- // Fuse LdaNull/LdaUndefined followed by a equality comparison with test
- // undetectable. Testing undetectable is a simple check on the map which is
- // more efficient than the full comparison operation.
- if (last == Bytecode::kLdaNull || last == Bytecode::kLdaUndefined) {
- if (current == Bytecode::kTestEqual) {
- return {PeepholeAction::kTransformEqualityWithNullOrUndefinedAction,
- Bytecode::kTestUndetectable};
- }
- }
-
- // Fuse LdaNull/LdaUndefined followed by a strict equals with
- // TestNull/TestUndefined.
- if (current == Bytecode::kTestEqualStrict) {
- if (last == Bytecode::kLdaNull) {
- return {PeepholeAction::kTransformEqualityWithNullOrUndefinedAction,
- Bytecode::kTestNull};
- } else if (last == Bytecode::kLdaUndefined) {
- return {PeepholeAction::kTransformEqualityWithNullOrUndefinedAction,
- Bytecode::kTestUndefined};
- }
- }
-
// If there is no last bytecode to optimize against, store the incoming
// bytecode or for jumps emit incoming bytecode immediately.
if (last == Bytecode::kIllegal) {
« no previous file with comments | « src/interpreter/interpreter-generator.cc ('k') | test/cctest/interpreter/bytecode_expectations/CompareNil.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698