Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2793863002: Revert of Remove the 10 second delay before user input generates engagement. (Closed)

Created:
3 years, 8 months ago by dominickn
Modified:
3 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove the 10 second delay before user input generates engagement. (patchset #1 id:1 of https://codereview.chromium.org/2693403003/ ) Reason for revert: This caused a perf regression (crbug.com/699749) Original issue's description: > Remove the 10 second delay before user input generates engagement. > > The site engagement service currently waits 10 seconds after > navigation completes before allowing user input to generate engagement. > This reduces the predictability of the service. Engagement also decays > much more quickly now, meaning that the additional engagement earned > when removing the 10 second wait is negligible. > > This CL instead allows engagement to be earned from the moment that the > page finishes loading. > > BUG=692878 > > Review-Url: https://codereview.chromium.org/2693403003 > Cr-Commit-Position: refs/heads/master@{#451942} > Committed: https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b5df208f53420 TBR=benwells@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=692878 Review-Url: https://codereview.chromium.org/2793863002 Cr-Commit-Position: refs/heads/master@{#461365} Committed: https://chromium.googlesource.com/chromium/src/+/14a17fb865e7f8925ad4f96ad0a810fb83056c1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/engagement/site_engagement_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/engagement/site_engagement_helper.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
dominickn
Created Revert of Remove the 10 second delay before user input generates engagement.
3 years, 8 months ago (2017-04-03 02:41:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2793863002/1
3 years, 8 months ago (2017-04-03 02:41:25 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 03:26:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14a17fb865e7f8925ad4f96ad0a8...

Powered by Google App Engine
This is Rietveld 408576698