Remove the 10 second delay before user input generates engagement.

Remove the 10 second delay before user input generates engagement.

The site engagement service currently waits 10 seconds after
navigation completes before allowing user input to generate engagement.
This reduces the predictability of the service. Engagement also decays
much more quickly now, meaning that the additional engagement earned
when removing the 10 second wait is negligible.

This CL instead allows engagement to be earned from the moment that the
page finishes loading.

BUG=692878
Review-Url: https://codereview.chromium.org/2693403003
Cr-Commit-Position: refs/heads/master@{#451942}
Committed: https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b5df208f53420

[dominickn, 2017-02-16 06:07:36]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 06:08:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 08:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 08:35:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dominickn, 2017-02-21 03:06:36]

dominickn@chromium.org changed reviewers:
+ benwells@chromium.org

[dominickn, 2017-02-21 03:06:36]

PTAL, thanks!

This could be done slightly more efficiently by removing the post tasking or
shifting the start of tracking into DidFinishLoad. Both of those options make
testing significantly more complicated (right now it's easy because we can
completely control the navigation, but we can't fire the load event or trigger
callbacks very easily)

[benwells, 2017-02-21 03:13:27]

On 2017/02/21 03:06:36, dominickn wrote:
> PTAL, thanks!
> 
> This could be done slightly more efficiently by removing the post tasking or
> shifting the start of tracking into DidFinishLoad. Both of those options make
> testing significantly more complicated (right now it's easy because we can
> completely control the navigation, but we can't fire the load event or trigger
> callbacks very easily)

Before reviewing I've asked for some more details on the bug about the reasons
for doing this.

[benwells, 2017-02-22 00:39:22]

lgtm

[dominickn, 2017-02-22 00:42:00]

Description was changed from

==========
Remove the 10 second delay before user input generates engagement.

The site engagement service currently waits 10 seconds after
navigation completes before allowing user input to generate engagement.
This reduces the predictability of the service.

This CL instead allows engagement to be earned from the moment that the
page finishes loading.

BUG=692878
==========

to

==========
Remove the 10 second delay before user input generates engagement.

The site engagement service currently waits 10 seconds after
navigation completes before allowing user input to generate engagement.
This reduces the predictability of the service. Engagement also decays
much more quickly now, meaning that the additional engagement earned
when removing the 10 second wait is negligible.

This CL instead allows engagement to be earned from the moment that the
page finishes loading.

BUG=692878
==========

[dominickn, 2017-02-22 00:42:05]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:43:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:46:25]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[dominickn, 2017-02-22 03:38:19]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:39:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:00:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487734699403520, "parent_rev":
"e07cf60f84106241ccd5093e5ad3dc23f01e8b7d", "commit_rev":
"5ae55b8c8ed39e3a1019afba988b5df208f53420"}

[commit-bot: I haz the power, 2017-02-22 09:00:41]

Description was changed from

==========
Remove the 10 second delay before user input generates engagement.

The site engagement service currently waits 10 seconds after
navigation completes before allowing user input to generate engagement.
This reduces the predictability of the service. Engagement also decays
much more quickly now, meaning that the additional engagement earned
when removing the 10 second wait is negligible.

This CL instead allows engagement to be earned from the moment that the
page finishes loading.

BUG=692878
==========

to

==========
Remove the 10 second delay before user input generates engagement.

The site engagement service currently waits 10 seconds after
navigation completes before allowing user input to generate engagement.
This reduces the predictability of the service. Engagement also decays
much more quickly now, meaning that the additional engagement earned
when removing the 10 second wait is negligible.

This CL instead allows engagement to be earned from the moment that the
page finishes loading.

BUG=692878

Review-Url: https://codereview.chromium.org/2693403003
Cr-Commit-Position: refs/heads/master@{#451942}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b...
==========

[commit-bot: I haz the power, 2017-02-22 09:00:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ae55b8c8ed39e3a1019afba988b...

[dominickn, 2017-04-03 02:41:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2793863002/ by dominickn@chromium.org.

The reason for reverting is: This caused a perf regression (crbug.com/699749).